From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C22EB64DD for ; Sat, 29 Jul 2023 00:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231939AbjG2Adb (ORCPT ); Fri, 28 Jul 2023 20:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbjG2Ad0 (ORCPT ); Fri, 28 Jul 2023 20:33:26 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E30EE30DA for ; Fri, 28 Jul 2023 17:33:24 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-55adfa61199so1891290a12.2 for ; Fri, 28 Jul 2023 17:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1690590804; x=1691195604; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ahyJuXZ5mL1EHkAmnBhtpjxq5pGjH0m9c44cFqu9RR8=; b=xpUdgokS5I3D2dS83HRiHhZiG56m5FAIJgE/jlbqlE+gYcIRkpxvSi/pZSlUi7sy2z bnqqAIfSeRVJ95s1lcZAuogwJigMtlZdlSs+YHeoYBnYTHfZR6Zk4ahWvPG1AaLULQhY gO+eJNi8wd3w5WbQ9DO9D/sOeD3bA9T5kHZwOM7wmJcQvePox0iYtRM8wYAC7n/dDaqK X7P0sDk/dcUAgQAqq7D+U55LcixXdO1mjn96aqshgDPBbaKb46v56++fUbVWhXcdTM5a esvqsFXNPN843wzsRhz3BzbNQN9oUX4Gbmjl8FepRs+P4u+4Q+dnrBblDHu1hpf9MbwM y3zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690590804; x=1691195604; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ahyJuXZ5mL1EHkAmnBhtpjxq5pGjH0m9c44cFqu9RR8=; b=ZBb5fSEP+fykYIm5EBkT4CND9ghWRCHTPr5GDYSREXlvU6g6L0e8IQtG06KzpZQthb yFSsguP4J/nikBv6d2U10VTG2eggHRj4iHdlT53h9gbI8j1pmjehI0Y6dZRl2xfn45Oy 1eAyEvpdftp44qF59XpxjX+Q4BdkXRKUY8b15u2HisUhM7IvZrQnVFOnHFLYrycExX3p 64E6wKvBm/LkgFjE7fjNsqbKQMOO5URTM//+trttB/EIwnRXmSxHRy072APjIVNEtVFe ntfkXIhntGrvh4oDNGYf0epBk+rYSR4BKXPPWk2I7K+KS1pfu4qoT8vARha3+Pp9nIJB 8iLw== X-Gm-Message-State: ABy/qLYBmUR4MtevZROArMwDBEVjIWLkIazn1BN/+rxkNg6N2edG1Ra6 CTZDT1gPAtAgDAfZsb8UEAFfyQ== X-Google-Smtp-Source: APBJJlFS9zLP1c6phrba+UHvupDG9E3d4F06JGpS2iM7oXYYOuggQ3ope9iTdf44U6BdBCqfanr6PA== X-Received: by 2002:a17:902:9a06:b0:1bb:edd5:4644 with SMTP id v6-20020a1709029a0600b001bbedd54644mr2869632plp.68.1690590804391; Fri, 28 Jul 2023 17:33:24 -0700 (PDT) Received: from x1 ([2601:1c2:1800:f680:ab2e:71c2:3a28:319c]) by smtp.gmail.com with ESMTPSA id s13-20020a170902ea0d00b001b9be3b94e5sm4140174plg.303.2023.07.28.17.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 17:33:24 -0700 (PDT) Date: Fri, 28 Jul 2023 17:33:22 -0700 From: Drew Fustini To: guoren@kernel.org Cc: palmer@rivosinc.com, paul.walmsley@sifive.com, falcon@tinylab.org, bjorn@kernel.org, conor.dooley@microchip.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, stable@vger.kernel.org, Guo Ren Subject: Re: [PATCH V2 0/2] riscv: stack: Fixup independent softirq/irq stack for CONFIG_FRAME_POINTER=n Message-ID: References: <20230716001506.3506041-1-guoren@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230716001506.3506041-1-guoren@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 15, 2023 at 08:15:04PM -0400, guoren@kernel.org wrote: > From: Guo Ren > > The independent softirq/irq stack uses s0 to save & restore sp, but s0 > would be corrupted when CONFIG_FRAME_POINTER=n. So add s0 in the clobber > list to fix the problem. > > <+0>: addi sp,sp,-32 > <+2>: sd s0,16(sp) > <+4>: sd s1,8(sp) > <+6>: sd ra,24(sp) > <+8>: sd s2,0(sp) > <+10>: mv s0,a0 --> compiler allocate s0 for a0 when CONFIG_FRAME_POINTER=n > <+12>: jal ra,0xffffffff800bc0ce > <+16>: ld a5,56(tp) # 0x38 > <+20>: lui a4,0x4 > <+22>: mv s1,a0 > <+24>: xor a5,a5,sp > <+28>: bgeu a5,a4,0xffffffff800bc092 > <+32>: auipc s2,0x5d > <+36>: ld s2,1118(s2) # 0xffffffff801194b8 > <+40>: add s2,s2,a4 > <+42>: addi sp,sp,-8 > <+44>: sd ra,0(sp) > <+46>: addi sp,sp,-8 > <+48>: sd s0,0(sp) > <+50>: addi s0,sp,16 --> our code clobber the s0 > <+52>: mv sp,s2 > <+54>: mv a0,s0 --> a0 got wrong value for handle_riscv_irq > <+56>: jal ra,0xffffffff800bbb3a > > Changelog: > V2 > - Fixup compile error with CONFIG_FRAME_POINTER=y > - FIxup stable@vger.kernel.org tag > > Guo Ren (2): > riscv: stack: Fixup independent irq stack for CONFIG_FRAME_POINTER=n > riscv: stack: Fixup independent softirq stack for > CONFIG_FRAME_POINTER=n > > arch/riscv/kernel/irq.c | 3 +++ > arch/riscv/kernel/traps.c | 3 +++ > 2 files changed, 6 insertions(+) > > -- > 2.36.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv Tested-by: Drew Fustini Xi Ruoyao noticed that the mainline kernel crashed when using a kernel config with CONFIG_FRAME_POINTER=n. I was able to reproduce this [1]. Emil suggested I trying this patche series. I can confirm that this resolves the kernel crash on the Sipeed Lichee Pi4a [2]. Thanks, Drew [1] https://lore.kernel.org/linux-riscv/ZMNojqwLxcG8FcHN@x1/ [2] https://lore.kernel.org/linux-riscv/ZMQAqUfb0y%2FigQs2@x1/