* Re: [PATCH net-next] net/smc: Remove unused function declarations
2023-07-29 12:19 [PATCH net-next] net/smc: Remove unused function declarations Yue Haibing
@ 2023-07-30 17:25 ` Simon Horman
2023-07-31 2:11 ` Tony Lu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2023-07-30 17:25 UTC (permalink / raw)
To: Yue Haibing
Cc: kgraul, wenjia, jaka, alibuda, tonylu, guwen, davem, edumazet,
kuba, pabeni, linux-s390, netdev, linux-kernel
On Sat, Jul 29, 2023 at 08:19:29PM +0800, Yue Haibing wrote:
> commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()")
> left behind smc_lgr_schedule_free_work_fast() declaration.
> And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
> smc_ib_modify_qp_reset() is not used anymore.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net/smc: Remove unused function declarations
2023-07-29 12:19 [PATCH net-next] net/smc: Remove unused function declarations Yue Haibing
2023-07-30 17:25 ` Simon Horman
@ 2023-07-31 2:11 ` Tony Lu
2023-07-31 7:26 ` Wenjia Zhang
2023-07-31 21:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Tony Lu @ 2023-07-31 2:11 UTC (permalink / raw)
To: Yue Haibing
Cc: kgraul, wenjia, jaka, alibuda, guwen, davem, edumazet, kuba,
pabeni, linux-s390, netdev, linux-kernel
On Sat, Jul 29, 2023 at 08:19:29PM +0800, Yue Haibing wrote:
> commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()")
> left behind smc_lgr_schedule_free_work_fast() declaration.
> And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
> smc_ib_modify_qp_reset() is not used anymore.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
LGTM, thanks.
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> net/smc/smc_core.h | 1 -
> net/smc/smc_ib.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/net/smc/smc_core.h b/net/smc/smc_core.h
> index 1645fba0d2d3..3c1b31bfa1cf 100644
> --- a/net/smc/smc_core.h
> +++ b/net/smc/smc_core.h
> @@ -539,7 +539,6 @@ int smc_vlan_by_tcpsk(struct socket *clcsock, struct smc_init_info *ini);
>
> void smc_conn_free(struct smc_connection *conn);
> int smc_conn_create(struct smc_sock *smc, struct smc_init_info *ini);
> -void smc_lgr_schedule_free_work_fast(struct smc_link_group *lgr);
> int smc_core_init(void);
> void smc_core_exit(void);
>
> diff --git a/net/smc/smc_ib.h b/net/smc/smc_ib.h
> index 034295676e88..4df5f8c8a0a1 100644
> --- a/net/smc/smc_ib.h
> +++ b/net/smc/smc_ib.h
> @@ -96,7 +96,6 @@ void smc_ib_destroy_queue_pair(struct smc_link *lnk);
> int smc_ib_create_queue_pair(struct smc_link *lnk);
> int smc_ib_ready_link(struct smc_link *lnk);
> int smc_ib_modify_qp_rts(struct smc_link *lnk);
> -int smc_ib_modify_qp_reset(struct smc_link *lnk);
> int smc_ib_modify_qp_error(struct smc_link *lnk);
> long smc_ib_setup_per_ibdev(struct smc_ib_device *smcibdev);
> int smc_ib_get_memory_region(struct ib_pd *pd, int access_flags,
> --
> 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net/smc: Remove unused function declarations
2023-07-29 12:19 [PATCH net-next] net/smc: Remove unused function declarations Yue Haibing
2023-07-30 17:25 ` Simon Horman
2023-07-31 2:11 ` Tony Lu
@ 2023-07-31 7:26 ` Wenjia Zhang
2023-07-31 21:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Wenjia Zhang @ 2023-07-31 7:26 UTC (permalink / raw)
To: Yue Haibing, kgraul, jaka, alibuda, tonylu, guwen, davem,
edumazet, kuba, pabeni
Cc: linux-s390, netdev, linux-kernel
On 29.07.23 14:19, Yue Haibing wrote:
> commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()")
> left behind smc_lgr_schedule_free_work_fast() declaration.
> And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
> smc_ib_modify_qp_reset() is not used anymore.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Thank you for the findings!
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net/smc: Remove unused function declarations
2023-07-29 12:19 [PATCH net-next] net/smc: Remove unused function declarations Yue Haibing
` (2 preceding siblings ...)
2023-07-31 7:26 ` Wenjia Zhang
@ 2023-07-31 21:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-31 21:50 UTC (permalink / raw)
To: Yue Haibing
Cc: kgraul, wenjia, jaka, alibuda, tonylu, guwen, davem, edumazet,
kuba, pabeni, linux-s390, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 29 Jul 2023 20:19:29 +0800 you wrote:
> commit f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()")
> left behind smc_lgr_schedule_free_work_fast() declaration.
> And since commit 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
> smc_ib_modify_qp_reset() is not used anymore.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> [...]
Here is the summary with links:
- [net-next] net/smc: Remove unused function declarations
https://git.kernel.org/netdev/net-next/c/4cbc32a8a2b4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread