From: Simon Horman <horms@kernel.org>
To: Suman Ghosh <sumang@marvell.com>
Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, lcherian@marvell.com,
jerinj@marvell.com, simon.horman@corigine.com
Subject: Re: [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support for inner VLAN
Date: Mon, 31 Jul 2023 09:03:52 +0200 [thread overview]
Message-ID: <ZMdc2Aca5AbvPKS1@kernel.org> (raw)
In-Reply-To: <20230730080009.2842927-3-sumang@marvell.com>
On Sun, Jul 30, 2023 at 01:30:09PM +0530, Suman Ghosh wrote:
> This patch extends current TC flower offload support to allow filters
> involving inner VLAN matching, to be offloaded to HW.
>
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
...
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> index f311fa6db7ce..29565680f6c4 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> @@ -447,10 +447,11 @@ static int otx2_tc_process_vlan(struct otx2_nic *nic, struct flow_msg *flow_spec
> u16 vlan_tci, vlan_tci_mask;
>
> if (is_inner)
> - return -EOPNOTSUPP;
> + flow_rule_match_cvlan(rule, &match);
> + else
> + flow_rule_match_vlan(rule, &match);
>
> - flow_rule_match_vlan(rule, &match);
> - if (ntohs(match.key->vlan_tpid) != ETH_P_8021Q) {
> + if (!eth_type_vlan(ntohs(match.key->vlan_tpid))) {
Hi Suman,
I think this should be:
if (!eth_type_vlan(match.key->vlan_tpid)) {
Otherwise the patch-set looks good to me.
> netdev_err(nic->netdev, "vlan tpid 0x%x not supported\n",
> ntohs(match.key->vlan_tpid));
> return -EOPNOTSUPP;
...
next prev parent reply other threads:[~2023-07-31 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 8:00 [net-next PATCH V2 0/2] octeontx2-af: Code restructuting and new Suman Ghosh
2023-07-30 8:00 ` [net-next PATCH V2 1/2] octeontx2-af: Code restructure to handle TC outer VLAN offload Suman Ghosh
2023-07-30 8:00 ` [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support for inner VLAN Suman Ghosh
2023-07-31 7:03 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-30 14:31 [net-next PATCH V2 0/2] octeontx2-af: TC flower offload changes Suman Ghosh
2023-07-30 14:31 ` [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support for inner VLAN Suman Ghosh
2023-07-31 17:24 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMdc2Aca5AbvPKS1@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=simon.horman@corigine.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox