From: Tejun Heo <tj@kernel.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com,
peterz@infradead.org
Subject: Re: [RFC PATCH 0/2] workqueue: Introduce PF_WQ_RESCUE_WORKER
Date: Mon, 31 Jul 2023 13:35:45 -1000 [thread overview]
Message-ID: <ZMhFUbL42Ycyc2tI@slm.duckdns.org> (raw)
In-Reply-To: <20230729135334.566138-1-atomlin@atomlin.com>
Hello,
On Sat, Jul 29, 2023 at 02:53:32PM +0100, Aaron Tomlin wrote:
> It can be useful to identify a rescue kworker since their CPU affinity
> cannot be modified and their initial CPU assignment can be safely ignored.
You really shouldn't be setting affinities on kworkers manually. There's no
way of knowing which kworker is going to execute which workqueue. Please use
the attributes API and sysfs interface to modify per-workqueue worker
attributes. If that's not sufficient and you need finer grained control, the
right thing to do is using kthread_worker which gives you a dedicated
kthread that you can manipulate as appropriate.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-07-31 23:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 13:53 [RFC PATCH 0/2] workqueue: Introduce PF_WQ_RESCUE_WORKER Aaron Tomlin
2023-07-29 13:53 ` [RFC PATCH 1/2] " Aaron Tomlin
2023-07-29 16:07 ` Peter Zijlstra
2023-08-01 10:04 ` Aaron Tomlin
2023-07-29 13:53 ` [RFC PATCH 2/2] workqueue: Simplify current_is_workqueue_rescuer() Aaron Tomlin
2023-07-31 23:35 ` Tejun Heo [this message]
2023-08-01 10:53 ` [RFC PATCH 0/2] workqueue: Introduce PF_WQ_RESCUE_WORKER Aaron Tomlin
2023-08-02 18:10 ` Tejun Heo
2023-08-03 20:19 ` Aaron Tomlin
2023-08-03 20:34 ` Tejun Heo
2023-08-05 23:45 ` Aaron Tomlin
2023-12-11 14:51 ` Juri Lelli
2023-12-11 18:39 ` Tejun Heo
2023-12-12 9:56 ` Juri Lelli
2023-12-12 17:14 ` Tejun Heo
2023-12-12 19:06 ` Aaron Tomlin
2023-12-12 20:16 ` Tejun Heo
2023-12-13 8:59 ` Juri Lelli
2023-12-13 15:35 ` Tejun Heo
2023-12-13 18:32 ` Juri Lelli
2023-12-13 18:38 ` Tejun Heo
2023-12-14 11:25 ` Juri Lelli
2023-12-14 19:47 ` Tejun Heo
2023-12-15 6:50 ` Juri Lelli
2023-12-19 8:55 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMhFUbL42Ycyc2tI@slm.duckdns.org \
--to=tj@kernel.org \
--cc=atomlin@atomlin.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox