From: Stephan Gerhold <stephan@gerhold.net>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 01/10] interconnect: qcom: icc-rpm: Add AB/IB calculations coefficients
Date: Tue, 1 Aug 2023 12:53:48 +0200 [thread overview]
Message-ID: <ZMjkPLqBiWW8CpAU@gerhold.net> (raw)
In-Reply-To: <20230726-topic-icc_coeff-v2-1-8c91c6c76076@linaro.org>
On Mon, Jul 31, 2023 at 12:52:17PM +0200, Konrad Dybcio wrote:
> Presumably due to the hardware being so complex, some nodes (or busses)
> have different (usually higher) requirements for bandwidth than what
> the usual calculations would suggest.
>
> Looking at the available downstream files, it seems like AB values are
> adjusted per-bus and IB values are adjusted per-node.
> With that in mind, introduce percentage-based coefficient struct members
> and use them in the calculations.
>
> One thing to note is that the IB coefficient is inverse (100/ib_percent)
> which feels a bit backwards, but it's necessary for precision..
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/interconnect/qcom/icc-rpm.c | 14 +++++++++++---
> drivers/interconnect/qcom/icc-rpm.h | 6 ++++++
> 2 files changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index 2c16917ba1fd..a837d20af79e 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -298,7 +298,8 @@ static int qcom_icc_bw_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
> */
> static void qcom_icc_bus_aggregate(struct icc_provider *provider, u64 *agg_clk_rate)
> {
> - u64 agg_avg_rate, agg_rate;
> + struct qcom_icc_provider *qp = to_qcom_provider(provider);
> + u64 agg_avg_rate, agg_peak_rate, agg_rate;
> struct qcom_icc_node *qn;
> struct icc_node *node;
> int i;
> @@ -315,8 +316,15 @@ static void qcom_icc_bus_aggregate(struct icc_provider *provider, u64 *agg_clk_r
> else
> agg_avg_rate = qn->sum_avg[i];
>
> - agg_rate = max_t(u64, agg_avg_rate, qn->max_peak[i]);
> - do_div(agg_rate, qn->buswidth);
> + if (qp->ab_coeff)
> + agg_avg_rate = mult_frac(qp->ab_coeff, agg_avg_rate, 100);
agg_avg_rate * (qp->ab_coeff / 100) would feel more logical to me (even
if it should be the same), i.e.
agg_avg_rate = mult_frac(agg_avg_rate, qp->ab_coeff, 100);
Not sure why you swapped them.
> +
> + if (qp->ib_coeff)
> + agg_peak_rate = mult_frac(100, qn->max_peak[i], qp->ib_coeff);
agg_peak_rate = mult_frac(qn->max_peak[i], 100, qp->ib_coeff);
Anyway, looks like you need to avoid mult_frac anyway for ARM32 compat :/
arm-none-eabi-ld: drivers/interconnect/qcom/icc-rpm.o: in function `qcom_icc_calc_rate':
drivers/interconnect/qcom/icc-rpm.c:310: undefined reference to `__aeabi_uldivmod'
arm-none-eabi-ld: drivers/interconnect/qcom/icc-rpm.c:312: undefined reference to `__aeabi_uldivmod'
Thanks,
Stephan
next prev parent reply other threads:[~2023-08-01 11:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 10:52 [PATCH v2 00/10] Fix up icc clock rate calculation on some platforms Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 01/10] interconnect: qcom: icc-rpm: Add AB/IB calculations coefficients Konrad Dybcio
2023-08-01 10:53 ` Stephan Gerhold [this message]
2023-07-31 10:52 ` [PATCH v2 02/10] interconnect: qcom: icc-rpm: Separate out clock rate calulcations Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 03/10] interconnect: qcom: icc-rpm: Let nodes drive their own bus clock Konrad Dybcio
2023-08-01 10:58 ` Stephan Gerhold
2023-08-01 11:29 ` Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 04/10] interconnect: qcom: icc-rpm: Check for node-specific rate coefficients Konrad Dybcio
2023-08-01 11:01 ` Stephan Gerhold
2023-07-31 10:52 ` [PATCH v2 05/10] interconnect: qcom: qcm2290: Hook up MAS_APPS_PROC's bus clock Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 06/10] interconnect: qcom: qcm2290: Set AB coefficients Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 07/10] interconnect: qcom: qcm2290: Update EBI channel configuration Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 08/10] interconnect: qcom: sdm660: Set AB/IB coefficients Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 09/10] interconnect: qcom: msm8996: " Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 10/10] clk: qcom: smd-rpm: Move CPUSS_GNoC clock to interconnect Konrad Dybcio
2023-08-04 16:31 ` [PATCH v2 00/10] Fix up icc clock rate calculation on some platforms Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMjkPLqBiWW8CpAU@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox