From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E4CC04A6A for ; Tue, 1 Aug 2023 18:31:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbjHASbR (ORCPT ); Tue, 1 Aug 2023 14:31:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbjHASbN (ORCPT ); Tue, 1 Aug 2023 14:31:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 704EF1FFC; Tue, 1 Aug 2023 11:31:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE05E61680; Tue, 1 Aug 2023 18:31:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB89AC433C7; Tue, 1 Aug 2023 18:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690914671; bh=Z6iZx1MnTkv+z0S9RMruiULP5AWXR+HZFjpUnj/UERQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N5LVZ7LDQp9HZ+iARzkaUjXd/VCMsWt8Jbz0Vel41HptW9Wd0B92SfnMtueHunSq3 vSfaca7LlT3VFnnwIpht+3GkkspvAfpgWoJ7Mye7No4vB4QdzaLLnDE1ZigLN63Nh5 XkOPEGTSXZtsLTW+cP7OZplKGglZdgjiR68Uolpc2zYbBpEsnMmE18UG97elC12Zao Ne+YBLfJWQnZw3s2OHKugQgdWiY+KR1zQt+VW9HWLDssASnbmj8gBNcaRpsIU8SbwE F8wSyL0yKoUIirWrbZnFQGkfPbq/REDNlPMq0nO6eUhSRZVyI2c2X9GjuqydS2UDnf U4jJ9pRhCeJUw== Date: Wed, 2 Aug 2023 00:01:07 +0530 From: Vinod Koul To: sunran001@208suo.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: idxd: No need to clear memory after a dma_alloc_coherent() call Message-ID: References: <20230721073440.5402-1-xujianghui@cdjrlc.com> <0bd20a5f09b3419e1d4d8c2b6786e886@208suo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bd20a5f09b3419e1d4d8c2b6786e886@208suo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-07-23, 07:35, sunran001@208suo.com wrote: > dma_alloc_coherent() already clear the allocated memory, there is no need > to explicitly call memset(). Please fix the sender name and resend. it should match s-o-b name > > Signed-off-by: Ran Sun > --- > drivers/dma/idxd/device.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c > index 7c74bc60f582..72330876d40a 100644 > --- a/drivers/dma/idxd/device.c > +++ b/drivers/dma/idxd/device.c > @@ -792,7 +792,6 @@ static int idxd_device_evl_setup(struct idxd_device > *idxd) > evl->log_size = size; > evl->bmap = bmap; > > - memset(&evlcfg, 0, sizeof(evlcfg)); > evlcfg.bits[0] = dma_addr & GENMASK(63, 12); > evlcfg.size = evl->size; -- ~Vinod