Re: [PATCH v1 0/4] Intel metric fixes and event updates

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, Aug 01, 2023 at 01:48:45PM -0400, Liang, Kan escreveu:
> 
> 
> On 2023-08-01 1:36 a.m., Ian Rogers wrote:
> > The metric tma_info_pipeline_retire contains uops_retired.slots with
> > perf metric events. Patch 1 fixes this event sorting so that
> > uops_retired.slots isn't made a group leader as that needs to be
> > topdown.slots.
> > 
> > Patch 2 and 3 update the meteorlake and sapphirerapids events.
> > 
> > Patch 4 addresses an issue with event grouping discussed in:
> > https://lore.kernel.org/lkml/20230719001836.198363-3-irogers@google.com/
> > by adding and altering metric constraints. The constraints avoid
> > groups for metrics where the kernel PMU fails to not open the group
> > (the trigger for the weak group being removed).
> > 
> > Ian Rogers (4):
> >   perf parse-events x86: Avoid sorting uops_retired.slots
> >   perf vendor events intel: Update meteorlake to 1.04
> >   perf vendor events intel: Update sapphirerapids to 1.15
> >   perf vendor events intel: Update Icelake+ metric constraints
> >
> 
> Thanks Ian.
> 
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks, applied.

- Arnaldo