From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 830E5C04A6A for ; Thu, 3 Aug 2023 20:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbjHCUvx (ORCPT ); Thu, 3 Aug 2023 16:51:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230523AbjHCUvv (ORCPT ); Thu, 3 Aug 2023 16:51:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 871E811F; Thu, 3 Aug 2023 13:51:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2576861EA5; Thu, 3 Aug 2023 20:51:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F0A4C433C8; Thu, 3 Aug 2023 20:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691095909; bh=V7wJi7Pcy7UiUd+kBOXn5BnCLDetBgZyMEtNsqBRtQE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TxDyQr/rp2VehgeKDNILgILbKe2f43HJdbXTkm9VDeoTf/qFkWd5S1oNSTJWBbInf FeG5syK5QK2w7BP79tRjHj8kll/wCvtg7OO78kpTa72GrI6QzsoDvrz/9d1PDLvywk asElkm2RNXb/dxGQOvRx3JeW0LpHuA+Txrnas6XURqIfMsi7VBay9EeFgLW3yr2fq3 4hx3vYPm3rrwDiG6R3FPCmJuAvHrumwloRtlTqO2JVHs6qSOJkPD83y0YQXjcWgcZg kzLI16Q37kP7DOkivNgd6ItfTQ3GoIRxz7JOhjCk26YTnQu0E5TddIp+0IQPpxqrPv 1Nf1z+UMYOInQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 48C58404DF; Thu, 3 Aug 2023 17:51:46 -0300 (-03) Date: Thu, 3 Aug 2023 17:51:46 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers , Adrian Hunter Cc: Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 1/3] perf dlfilter: Add a test for resolve_address() Message-ID: References: <20230731091857.10681-1-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731091857.10681-1-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jul 31, 2023 at 12:18:55PM +0300, Adrian Hunter escreveu: > Extend the "dlfilter C API" test to test > perf_dlfilter_fns.resolve_address(). The test currently fails, but passes > after a subsequent patch. Ian, I think this is ok now, can you please take a look and perhaps provide an Acked-by or Reviewed-by? - Arnaldo > Signed-off-by: Adrian Hunter > --- > tools/perf/dlfilters/dlfilter-test-api-v0.c | 26 ++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/dlfilters/dlfilter-test-api-v0.c b/tools/perf/dlfilters/dlfilter-test-api-v0.c > index b1f51efd67d6..72f263d49121 100644 > --- a/tools/perf/dlfilters/dlfilter-test-api-v0.c > +++ b/tools/perf/dlfilters/dlfilter-test-api-v0.c > @@ -254,6 +254,30 @@ static int check_addr_al(void *ctx) > return 0; > } > > +static int check_address_al(void *ctx, const struct perf_dlfilter_sample *sample) > +{ > + struct perf_dlfilter_al address_al; > + const struct perf_dlfilter_al *al; > + > + al = perf_dlfilter_fns.resolve_ip(ctx); > + if (!al) > + return test_fail("resolve_ip() failed"); > + > + address_al.size = sizeof(address_al); > + if (perf_dlfilter_fns.resolve_address(ctx, sample->ip, &address_al)) > + return test_fail("resolve_address() failed"); > + > + CHECK(address_al.sym && al->sym); > + CHECK(!strcmp(address_al.sym, al->sym)); > + CHECK(address_al.addr == al->addr); > + CHECK(address_al.sym_start == al->sym_start); > + CHECK(address_al.sym_end == al->sym_end); > + CHECK(address_al.dso && al->dso); > + CHECK(!strcmp(address_al.dso, al->dso)); > + > + return 0; > +} > + > static int check_attr(void *ctx) > { > struct perf_event_attr *attr = perf_dlfilter_fns.attr(ctx); > @@ -290,7 +314,7 @@ static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void > if (early && !d->do_early) > return 0; > > - if (check_al(ctx) || check_addr_al(ctx)) > + if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample)) > return -1; > > if (early) > -- > 2.34.1 > -- - Arnaldo