From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC9EEE4998 for ; Fri, 18 Aug 2023 22:34:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241236AbjHRWeJ (ORCPT ); Fri, 18 Aug 2023 18:34:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241074AbjHRWdu (ORCPT ); Fri, 18 Aug 2023 18:33:50 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4C5A4210 for ; Fri, 18 Aug 2023 15:33:48 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d27ac992539so1690607276.3 for ; Fri, 18 Aug 2023 15:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692398028; x=1693002828; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NhEwl8ITGQcTfYN5ElDC4AmBI4NmU0oAW6H6kQx3LJQ=; b=s+LHBPfCmaOjRDlN9GI/+ZGoEpD6ePDnRpVcb3uFtlONTsP9JqACJWMFtGw6mUO1f0 E1snrfpmK5kNjirXqCZS+5CA/iZQk2ncSRDAJ9x/Z+tcJL+fXx5UPxqxZ2bbOm9xoJ1D FT1Zd7xUcJtbGnM9WRvNt2IAZe0OMtgFrVbuiC9i7zz1bzXIoEPAkmPwUkyLH3cOi1Mg 3IfJgNHpXr1BQ8AuDPtwWBNE3Yz4r0bGkdIgL5KsFjNib1IaQ3khjAgtJMdtwxWJf1Bx 2S1zAs5/7aFOndGw+ptCV1YR83A4EShCLHivgvxnJEef2PcsY4uGcGQs86G/cxY9aa16 /tdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692398028; x=1693002828; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NhEwl8ITGQcTfYN5ElDC4AmBI4NmU0oAW6H6kQx3LJQ=; b=OXcow5kcdIpjAq0i3whYh/LdrEwwyFSumlpVRMJmLBk0g0Em8c4BNuTOBKlXlWYA3D tnVGvrIJ7wci8Cfccs6WbbCi/X8tWRAsizA6IAaMUj6I62Dw/n10u8OVBja/qteLNwkf IQFkoxahd4o+UjGUJRqu5figfmagjDvlZWDKJ6HYcJ1kYnecyUOd6XainRx80ykgob9W s9kfAG6D/18PE6shTkqvw9xDxB37FUHaEAEGojZSA/0hH+fsJxSRaMEvb+14rAe6F2VF 20oRzbixyKGajqx4thLGSq8RbiQtiiK3Ab1T/9UbwzS8QJll/lBvZXBRsMQbosSblOXv VMgg== X-Gm-Message-State: AOJu0Yzm4ZUS/5/lA6ClO5xpI74KtWRAXJkF1P8yNFvdnWVIyN6uBMpQ YCKmOEJVAcTslK23LJTygmCvrAwv7N4= X-Google-Smtp-Source: AGHT+IFH27W0J3FpLsSsyh6gpjSRTEpCWHOAm5ANIV7muCzGRClMm1/4A0wcNfxBy5CDeXjGqco/XUuVEJo= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1786:b0:d74:5e2c:4c5a with SMTP id ca6-20020a056902178600b00d745e2c4c5amr5154ybb.5.1692398028159; Fri, 18 Aug 2023 15:33:48 -0700 (PDT) Date: Fri, 18 Aug 2023 15:33:46 -0700 In-Reply-To: Mime-Version: 1.0 References: Message-ID: Subject: Re: [PATCH 3/8] KVM: gmem: Fix kvm_gmem_issue_arch_invalidate() From: Sean Christopherson To: isaku.yamahata@intel.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Michael Roth , Paolo Bonzini , erdemaktas@google.com, Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, linux-coco@lists.linux.dev, Chao Peng , Ackerley Tng , Vishal Annapurve , Yuan Yao , Jarkko Sakkinen , Xu Yilun , Quentin Perret , wei.w.wang@intel.com, Fuad Tabba Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 15, 2023, isaku.yamahata@intel.com wrote: > From: Isaku Yamahata > > __filemap_get_folio() can return error. Use IS_ERR_OR_NULL. > > Signed-off-by: Isaku Yamahata *sigh* (a) This patch is ordered incorrectly, it belongs after patch 6. (b) Don't post broken patches with fixup in the same damn series. This is not hard, these are basic rules of the road. Sorry for being grumpy, but I spent way too much time figuring out what on earth was going on, for something that should have required exactly _zero_ effort on my end.