From: Vinod Koul <vkoul@kernel.org>
To: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK
Date: Thu, 17 Aug 2023 12:16:27 +0530 [thread overview]
Message-ID: <ZN3CQ1Y3yC9p/01Y@matsya> (raw)
In-Reply-To: <6c02765f89eb4455806b895a6e0cb763@realtek.com>
On 17-08-23, 02:06, Stanley Chang[昌育德] wrote:
> Hi Geert,
>
> > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > --- a/drivers/phy/realtek/Kconfig
> > +++ b/drivers/phy/realtek/Kconfig
> > @@ -2,6 +2,9 @@
> > #
> > # Phy drivers for Realtek platforms
> > #
> > +
> > +if ARCH_REALTEK || COMPILE_TEST
> > +
> > config PHY_RTK_RTD_USB2PHY
> > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > depends on USB_SUPPORT
> > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > The DHC (digital home center) RTD series SoCs used the Synopsys
> > DWC3 USB IP. This driver will do the PHY initialization
> > of the parameters.
> > +
> > +endif # ARCH_REALTEK || COMPILE_TEST
>
> Thanks for your patch.
> Why not use "depends on"?
> depends on ARCH_MEDIATEK || COMPILE_TEST
I think this patch is better, this way all future rtek drivers will be
fixed as well, no need to add for each driver
--
~Vinod
next prev parent reply other threads:[~2023-08-17 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202308161422.37GEMlZkA018197@rtits1.realtek.com.tw>
2023-08-17 2:06 ` [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK Stanley Chang[昌育德]
2023-08-17 6:46 ` Vinod Koul [this message]
2023-08-17 6:53 ` Stanley Chang[昌育德]
2023-08-17 7:31 ` Geert Uytterhoeven
2023-09-28 7:56 ` Geert Uytterhoeven
2023-08-15 15:28 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN3CQ1Y3yC9p/01Y@matsya \
--to=vkoul@kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox