From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: drivers/gpio/gpio-pca9570.c:42: warning: Function parameter or member 'chip_data' not described in 'pca9570'
Date: Thu, 17 Aug 2023 12:55:41 +0300 [thread overview]
Message-ID: <ZN3undSeTOPCM/za@smile.fi.intel.com> (raw)
In-Reply-To: <202308171538.nKKUOtbg-lkp@intel.com>
On Thu, Aug 17, 2023 at 03:11:09PM +0800, kernel test robot wrote:
> Hi Bartosz,
...
> >> drivers/gpio/gpio-pca9570.c:42: warning: Function parameter or member 'chip_data' not described in 'pca9570'
Blame Bart for this :-)
> b8a34582c7f7f2 Shubhrajyoti Datta 2022-10-26 29
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 30 /**
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 31 * struct pca9570 - GPIO driver data
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 32 * @chip: GPIO controller chip
> b8a34582c7f7f2 Shubhrajyoti Datta 2022-10-26 33 * @p_data: GPIO controller platform data
So, should be @chip_data...
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 34 * @lock: Protects write sequences
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 35 * @out: Buffer for device register
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 36 */
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 37 struct pca9570 {
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 38 struct gpio_chip chip;
> a3f7c1d6ddcbd4 Bartosz Golaszewski 2022-12-30 39 const struct pca9570_chip_data *chip_data;
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 40 struct mutex lock;
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 41 u8 out;
> 16d44b6085c1d9 Sungbo Eo 2020-07-09 @42 };
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-17 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 7:11 drivers/gpio/gpio-pca9570.c:42: warning: Function parameter or member 'chip_data' not described in 'pca9570' kernel test robot
2023-08-17 9:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN3undSeTOPCM/za@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox