From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EDBC71143 for ; Fri, 18 Aug 2023 11:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376519AbjHRK74 (ORCPT ); Fri, 18 Aug 2023 06:59:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376507AbjHRK7t (ORCPT ); Fri, 18 Aug 2023 06:59:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 673A62708; Fri, 18 Aug 2023 03:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692356388; x=1723892388; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ArsRhl9lFuD/vKwJesp8W4PKFrP31bCab33WXlfDyIo=; b=Va4B4fgHffbI047IYtAQgNSNaklD5mVKR0TFIEhnMrFgcl4e0QsubcuF +n1JmAeiy7P865HLyB8YN8+v+DsgRnn/QhrfH/zrR+So/PgZ8SHgBk3eo QIuAgZV1WE2AfDblt8gLdgYfJXmRPFbU+znt5zwvb4BWxWz2HBMmIVF7S +8HxIQeKIIQMsh+R9C26YVLrY+YunrY1URYFvD/LAFUByygPrX+KT5hrH nDNHqhksaWgAJGQIDp19pReXg9SW7wLknXx/2rS0fMC9TeT9xXds5aVVU PuEYd20EseS9sDLmAeFXOzkF9j62YZ3LrV1c7xAngLcQlDS4FrpaXqnIt w==; X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="459429189" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208";a="459429189" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 03:59:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="878645077" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 18 Aug 2023 03:59:48 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qWxCg-004ldN-2c; Fri, 18 Aug 2023 13:59:42 +0300 Date: Fri, 18 Aug 2023 13:59:42 +0300 From: Andy Shevchenko To: Justin Chen Cc: linux-serial@vger.kernel.org, Al Cooper , Broadcom internal kernel review list , Greg Kroah-Hartman , Jiri Slaby , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Florian Fainelli , John Ogness , Jiaqing Zhao , "open list:TTY LAYER" Subject: Re: [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port Message-ID: References: <1692306801-13191-1-git-send-email-justin.chen@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1692306801-13191-1-git-send-email-justin.chen@broadcom.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2023 at 02:13:18PM -0700, Justin Chen wrote: > The 8250 BCM7271 UART is not a direct match to PORT_16550A and other > generic ports do not match its hardware capabilities. PORT_ALTR matches > the rx trigger levels, but its vendor configurations are not compatible. > Unfortunately this means we need to create another port to fully capture > the hardware capabilities of the BCM7271 UART. > > To alleviate some latency pressures, we default the rx trigger level to 8. ... > + .flags = UART_CAP_FIFO | UART_CAP_AFE Leave trailing comma ... > +/* Broadcom BCM7271 UART */ > +#define PORT_BCM7271 76 13 is free why not using it? -- With Best Regards, Andy Shevchenko