From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E04AFC7112B for ; Fri, 18 Aug 2023 11:22:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376620AbjHRLWA (ORCPT ); Fri, 18 Aug 2023 07:22:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376621AbjHRLVl (ORCPT ); Fri, 18 Aug 2023 07:21:41 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5896A3AB2; Fri, 18 Aug 2023 04:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692357700; x=1723893700; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CKRSS1iusdv1+5oh3j8yKQXBHN0I1ieRa1yex02/XD8=; b=Qo3UWgb/EViDQ2UH4qA2I9NmULITXiti1v8KOp/7RUY6Px7PbSLOryt3 MT2xVWtIDpO2EyOsDioJv4j+UsA3k8VBy9Tmu7THr1EYof8AGs6LEDyRU 5a6uU6EiCav85kG/KmNFk1cOtbqJ8XhdQgeXhd34kJulN0mlOdRkyGb2F QfAnVJBW6bRz4l5ixx1IqRGiHmzEi6FzDds60qIRPlBVdwsHhDDxVsm3e sv8Uq4U1nIXRv0mbdYSQbppNChpj5zlvu1/oVXCgEQtPGWfSTLbM8hMsQ 8g1HCTmx/eFNEyoAGrIfsVeFhIGD3UKpUCvEt6sH4hfP3FjbdHRuNwJXS A==; X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="370538362" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="370538362" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 04:21:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="728579674" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="728579674" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 18 Aug 2023 04:21:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qWxXs-005WEC-1U; Fri, 18 Aug 2023 14:21:36 +0300 Date: Fri, 18 Aug 2023 14:21:36 +0300 From: Andy Shevchenko To: Angel Iglesias Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen Subject: Re: [PATCH 2/2] iio: pressure: bmp280: Add support for BMP390 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2023 at 11:05:22PM +0200, Angel Iglesias wrote: > Adds BMP390 device id to the supported ids on bmp380 sensor family ... > #define BMP180_CHIP_ID 0x55 > #define BMP280_CHIP_ID 0x58 > #define BME280_CHIP_ID 0x60 > +#define BMP390_CHIP_ID 0x60 Keep it a bit better ordered. At the first glance, move before BME. -- With Best Regards, Andy Shevchenko