From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5411EC04A6A for ; Mon, 7 Aug 2023 15:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbjHGP1m (ORCPT ); Mon, 7 Aug 2023 11:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbjHGP1k (ORCPT ); Mon, 7 Aug 2023 11:27:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 854191710 for ; Mon, 7 Aug 2023 08:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691422054; x=1722958054; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sbOg8ZUo93mja+laQ8iw2rg2Pe9WY4tNS13a+NRdJq8=; b=iuvZ2rs3Rs+ePbVAZ7YXE2gvoMsuvdW2ex41aBShyM2h1sidYEZTfdN/ ah8+pL+/hMkJKGloMYhWgkXXLvUiJFee3n8x6GaSSVrVLITVa5/0Bxh7Q gyRuVGyMvmCFNhpDIvHiMCUS3ogFpLAVjMsyTNEwMaMaYp/nsGG4ECzv1 vnGFj+dV2mJfKVHDGit5tdvQ3ncexpmEBW3xLQAwyPI0zWjkjwJW+n6Fb f4nJoLq+UmvY/OKJF1ZK0/zrLfZ718M0u7+tyvrIjL6uw4TQajq0y+RtN TkYus2uHZizerQhoKlKRGUhGJgHeg5gpT9gApMbUmuTts+zM696ck4Oos A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="355513451" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="355513451" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 08:27:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="854698024" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="854698024" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 07 Aug 2023 08:27:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT28n-00HLi1-14; Mon, 07 Aug 2023 18:27:29 +0300 Date: Mon, 7 Aug 2023 18:27:28 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in sprintf.h Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 07, 2023 at 05:06:33PM +0200, Petr Mladek wrote: > On Sat 2023-08-05 20:50:27, Andy Shevchenko wrote: > > Sparse is not happy to see non-static variable without declaration: > > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > > > Declare respective variable in the sprintf.h. With this, add a comment > > to discourage its use if no real need. > If we agreed to move sprintf() declarations into printk.h > then this might go to printk.h as well. Sure, but I disagree with printk.h approach (as I explained why in the reply to the suggestion). -- With Best Regards, Andy Shevchenko