From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: xingtong_wu@163.com
Cc: ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
markgross@kernel.org, xingtong.wu@siemens.com, lee@kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, gerd.haeussler.ext@siemens.com,
tobias.schaffner@siemens.com, lkp@intel.com
Subject: Re: [PATCH v2 1/2] platform/x86/siemens: simatic-ipc: fix logic error in BX-59A
Date: Mon, 7 Aug 2023 18:56:14 +0300 [thread overview]
Message-ID: <ZNEUHo0fR280O4mN@smile.fi.intel.com> (raw)
In-Reply-To: <20430731173026.2631-2-xingtong_wu@163.com>
On Sat, Aug 01, 2043 at 01:30:26AM +0800, xingtong_wu@163.com wrote:
> From: "xingtong.wu" <xingtong.wu@siemens.com>
>
> The variable "ledmode" is missing from if statement that leads to
> a logical error. Add the missing variable to the if condition.
>
> Fixes: b8af77951941 ("platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307312322.Aa8upHWK-lkp@intel.com/
>
Blank lines are not allowed in the tag block.
> Signed-off-by: xingtong.wu <xingtong.wu@siemens.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-07 15:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 7:14 [PATCH 0/3] platform/x86: simatic-ipc: add another model BX-56A/BX-59A xingtong_wu
2023-07-31 7:14 ` [PATCH 1/3] platform/x86: simatic-ipc: add new models BX-56A/BX-59A xingtong_wu
2023-08-01 9:04 ` [PATCH 1/2] platform/x86/siemens: simatic-ipc: fix logic error in BX-59A xingtong_wu
2023-08-01 9:10 ` Hans de Goede
2023-08-04 13:41 ` Ilpo Järvinen
2043-07-31 17:30 ` [PATCH v2 0/2] fix logic errors " xingtong_wu
2043-07-31 17:30 ` [PATCH v2 1/2] platform/x86/siemens: simatic-ipc: fix logic error " xingtong_wu
2023-08-07 15:56 ` Andy Shevchenko [this message]
2043-08-02 17:35 ` [PATCH v3 0/2] fix logical errors for BX-59A xingtong_wu
2023-08-09 20:06 ` Hans de Goede
2043-08-02 17:35 ` [PATCH v3 1/2] platform/x86/siemens: simatic-ipc: fix logical error " xingtong_wu
2023-07-31 7:18 ` [PATCH 2/3] leds: simatic-ipc-leds-gpio: add support for module BX-59A xingtong_wu
2024-02-02 3:35 ` xingtong.wu
2024-02-02 12:42 ` [PATCH " Lee Jones
2023-07-31 7:21 ` [PATCH 3/3] batt: simatic-ipc-batt: " xingtong_wu
2023-08-01 9:07 ` [PATCH 2/2] platform/x86/siemens: simatic-ipc-batt: fix logic error for BX-59A xingtong_wu
2023-08-04 13:43 ` Ilpo Järvinen
2043-07-31 17:34 ` [PATCH v2 " xingtong_wu
2023-08-07 9:00 ` Ilpo Järvinen
2043-08-02 17:38 ` [PATCH v3 2/2] platform/x86/siemens: simatic-ipc-batt: fix logical " xingtong_wu
2023-08-16 15:45 ` [PATCH v2 2/2] platform/x86/siemens: simatic-ipc-batt: fix logic " Ashok Raj
2023-08-17 1:21 ` xingtong.wu
2023-07-31 12:36 ` [PATCH 0/3] platform/x86: simatic-ipc: add another model BX-56A/BX-59A Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNEUHo0fR280O4mN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gerd.haeussler.ext@siemens.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tobias.schaffner@siemens.com \
--cc=xingtong.wu@siemens.com \
--cc=xingtong_wu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox