From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D1EBC41513 for ; Mon, 7 Aug 2023 17:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbjHGRTf (ORCPT ); Mon, 7 Aug 2023 13:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232058AbjHGRTS (ORCPT ); Mon, 7 Aug 2023 13:19:18 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CA1E2100 for ; Mon, 7 Aug 2023 10:19:10 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d4ca2881833so2400870276.3 for ; Mon, 07 Aug 2023 10:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691428749; x=1692033549; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=27WqhWvu/ZsxgO0eaScHpZFEDzQn0I8scFjtchyFjMc=; b=tdqLt24osgHVvtPDkbBoS3gs2oYLYwf78ndKbYVPt6nuRqasJvTqaqHOTtXRjyk6dB TLa32Y4FjbMlQUmMgakR+L9b7u2unem/+pECTeIrmzmM5/poCie23rtV/gvmk4MQEp74 Ar7PDV1K4MGynfnCOGSPyHDwvrLh86FZKUUtLQ8Ec/sQ9yamEgcD83eWViiid2EFrMAM N4fM6cwbr1b5ApFSqs8OH15uoqDQYNQVCV8LNdaiEjZdN9m+twmh1JMr5eXxe/zT4YJh Oz8jknsiJLYGJZQ5IjHmfdUcLyKYzAn8638CMi8+lUY0jWEIOPzscXrnArwRiqNFoaR+ XN8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691428749; x=1692033549; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=27WqhWvu/ZsxgO0eaScHpZFEDzQn0I8scFjtchyFjMc=; b=QTi35OKdyAEykE7gmx/yf7Bq/pePBRX4/leOjLp7rGx/JBAxpvzbXQPlXfUlobDsDr +n1yIthGvOEgjqMiYyaJKG04Q1mH5xtKvRrTYkGJRx0PQcVwxPr3mHYfobcZsncVi5TD x6EHRHqm7hYfXMfIQijW1xfiM1R8+P30repLvKURkZ9BmdYOgSk7ANuZt7mnTAl9VjM7 4dR5odRvpuz+IVTWEEB6eFWzBla6tvKtPDn+WqPLE4qem9l70TO4/AW/uVdIpzafMOw2 x/6SZgY4/1o1MDfH+Yhb8iP0eH7YeOlC+NmG5RhU8nPDXCW+T3UcgyML6gIho2K3eOMv W01w== X-Gm-Message-State: AOJu0YwPYLeG6A63sTnj7fK3GADikFgUfGQrVa3omi9hagtY/vNm3kBu BrovwRfmgunFApVMSab1fPE8C+L+KXQ= X-Google-Smtp-Source: AGHT+IFApew+XDb0Q4kYRgsV58wREJAAY6JgXAxkEQkzqnSpBI8akykTQqeF+k7dKfbQrCT3r/q5RrMz++U= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:aa0e:0:b0:d0c:1f08:5fef with SMTP id s14-20020a25aa0e000000b00d0c1f085fefmr48511ybi.12.1691428749646; Mon, 07 Aug 2023 10:19:09 -0700 (PDT) Date: Mon, 7 Aug 2023 10:19:07 -0700 In-Reply-To: <5581418b-2e1c-6011-f0a4-580df7e00b44@gmail.com> Mime-Version: 1.0 References: <20221223005739.1295925-1-seanjc@google.com> <20221223005739.1295925-20-seanjc@google.com> <5581418b-2e1c-6011-f0a4-580df7e00b44@gmail.com> Message-ID: Subject: Re: [PATCH 19/27] KVM: x86/mmu: Use page-track notifiers iff there are external users From: Sean Christopherson To: Like Xu Cc: kvm@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yan Zhao , Ben Gardon , Zhi Wang , Paolo Bonzini , Zhenyu Wang Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 07, 2023, Like Xu wrote: > On 23/12/2022 8:57 am, Sean Christopherson wrote: > > +static inline void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, > > + const u8 *new, int bytes) > > +{ > > + __kvm_page_track_write(vcpu, gpa, new, bytes); > > + > > + kvm_mmu_track_write(vcpu, gpa, new, bytes); > > +} > > The kvm_mmu_track_write() is only used for x86, where the incoming parameter > "u8 *new" has not been required since 0e0fee5c539b ("kvm: mmu: Fix race in > emulated page table writes"), please help confirm if it's still needed ? Thanks. > A minor clean up is proposed. Hmm, unless I'm misreading things, KVMGT ultimately doesn't consume @new either. So I think we can remove @new from kvm_page_track_write() entirely. Feel free to send a patch, otherwise I'll get to it later this week.