From: Andy Shevchenko <andy@kernel.org>
To: Wenhua Lin <Wenhua.Lin@unisoc.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
wenhua lin <wenhua.lin1994@gmail.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Subject: Re: [PATCH 1/3] gpio: sprd: Modify the calculation method of eic number
Date: Tue, 8 Aug 2023 16:22:03 +0300 [thread overview]
Message-ID: <ZNJBe3wcTc8dA4JC@smile.fi.intel.com> (raw)
In-Reply-To: <20230808033106.2174-1-Wenhua.Lin@unisoc.com>
On Tue, Aug 08, 2023 at 11:31:06AM +0800, Wenhua Lin wrote:
> Automatic calculation through matching nodes,
> subsequent projects can avoid modifying driver files.
You sent three patches which has to be meant a series in three independent
(unlinked) messages. Do not forget to use --thread so it become a such.
...
> struct sprd_eic *sprd_eic;
> struct resource *res;
> int ret, i;
> + u16 num_banks = 0;
Preserve reversed xmas tree ordering.
...
> @@ -630,10 +631,12 @@ static int sprd_eic_probe(struct platform_device *pdev)
> sprd_eic->chip.set = sprd_eic_set;
> fallthrough;
> case SPRD_EIC_ASYNC:
> + fallthrough;
> case SPRD_EIC_SYNC:
> sprd_eic->chip.get = sprd_eic_get;
> break;
> case SPRD_EIC_LATCH:
> + fallthrough;
> default:
> break;
Pointless changes. And actually create the code less maintainable.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-08 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 3:31 [PATCH 1/3] gpio: sprd: Modify the calculation method of eic number Wenhua Lin
2023-08-08 13:22 ` Andy Shevchenko [this message]
2023-08-08 17:34 ` Hugo Villeneuve
2023-08-08 17:44 ` Hugo Villeneuve
2023-08-09 6:11 ` wenhua lin
2023-08-09 1:23 ` Baolin Wang
2023-08-09 6:08 ` wenhua lin
2023-08-09 13:02 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNJBe3wcTc8dA4JC@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Wenhua.Lin@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=wenhua.lin1994@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox