From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 322D0C04A6A for ; Tue, 8 Aug 2023 17:04:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbjHHREn (ORCPT ); Tue, 8 Aug 2023 13:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjHHRD7 (ORCPT ); Tue, 8 Aug 2023 13:03:59 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A12A519BEC; Tue, 8 Aug 2023 09:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691510507; x=1723046507; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EHzA/a69zS6IxZZOnKkr5lxAatAYM7/Zegj9a9NxFpQ=; b=L2mTFQQ6xOIsYJ1lu/fsK0ye3PE/grKcdGH/gbEIxeeG12T1h/8g84AQ MykDKsG08iTKj7unI+BO1mDbscBhlxm40lRbPCe/4wUPLZDhVZMnbV1YT 1sk+0Qwx5OFLeKYY+LCBwI8j9XoRiX35v5wbnLXm7/N9j6Vz5Vh6OfCpn hVMOwiGkrgNdkGBVl1+2BzPjIcqD89Zx6VckDnVsJyRxxX8wO6O/Y9hTP v4Gx5nGUjea6TLvTRHpRSWmYZZgSKQHDvUmEKaXzI1sz4ftzsASlDsTy+ gcBEXCGmUzqsBb/WHsz31pO/Tsckb5kNDWXJDQ8O2O9tV3z64ATcqqiDF A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="373569036" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="373569036" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 06:26:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="1062019916" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="1062019916" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 08 Aug 2023 06:26:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qTMj0-009guo-0A; Tue, 08 Aug 2023 16:26:14 +0300 Date: Tue, 8 Aug 2023 16:26:13 +0300 From: Andy Shevchenko To: Marcus Folkesson Cc: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cosmin Tanislav , Arnd Bergmann , ChiYuan Huang , Haibo Chen , Ramona Bolboaca , Ibrahim Tilki , ChiaEn Wu , William Breathitt Gray , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] iio: adc: mcp3911: add support for the whole MCP39xx family Message-ID: References: <20230807071831.4152183-1-marcus.folkesson@gmail.com> <20230807071831.4152183-2-marcus.folkesson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 09:22:24AM +0200, Marcus Folkesson wrote: > On Mon, Aug 07, 2023 at 06:53:21PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 07, 2023 at 09:18:31AM +0200, Marcus Folkesson wrote: ... > > > - ret = mcp3911_config(adc); > > > + ret = device_property_read_u32(&adc->spi->dev, "microchip,device-addr", &adc->dev_addr); > > > > Why not spi->dev? Ditto for other uses like this. > > After all, I think it is better to stick sith adc->spi-dev to be > consistent with the rest of the probe function. Change to spi->dev > should probably be a seperate patch. > Do you agree? Make sure you first switch to use shorter form and then add this one. In that case I agree. -- With Best Regards, Andy Shevchenko