From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A5F3C001B0 for ; Tue, 8 Aug 2023 20:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232847AbjHHUEC (ORCPT ); Tue, 8 Aug 2023 16:04:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234262AbjHHUDk (ORCPT ); Tue, 8 Aug 2023 16:03:40 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48EF68DC4B for ; Tue, 8 Aug 2023 11:21:53 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-564b8e60ce9so2782789a12.2 for ; Tue, 08 Aug 2023 11:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691518913; x=1692123713; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JmyLEGU8GSveXQW4ZwKDzQ9yMdM7AfBAEdQ4m4LJOnQ=; b=abrxRrd0sYsjaDd1GRFKwJ9nlXO94DqGiXr7ZuKo+O01p4pxbRXCrBUFBLE1aDmbQ3 wsY30SOQzfkNzCj/bCy9Xt9DI51lUoBHtGGM3JQsYlVsay/aEPrVmh+N2zbcFjhoL01U QkRjaFpVb1xh95xm8xeq9ILUL05tHSizKuNgaoQ1IKIOSYY1gCVmaHqUawsleyjGbQp5 1NMyoBj+bpqFpT0oflORFjNhiXRIZJ22UIbUa4WvKepS/SuimNUV5cWrxAXCP9qNiTc1 70F0VrWks96BEVtPx3J5dYiY5oE/LzDGQ6l/JHo8VUMC+YYQcRpfrDgRFiqhPMMPwVeO 35ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691518913; x=1692123713; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JmyLEGU8GSveXQW4ZwKDzQ9yMdM7AfBAEdQ4m4LJOnQ=; b=YPyijiqHrWt/H12rT1/ESTws4NOyRtW3F9kRRn2lh5QFI8zl7Z3neHFQsalEkCoMWL ZqWN1uYGJxa3hwrukcWQyYW2Dp9S+M5QChjDNfZrK0FWxxnXe/S9xpeuDGXZHAMn5j2c QGou1iFiz/hsCzxBNkHlzoL9td5pfuDEfxraKpNDFLiZk0VJT9jrJwVto3Omlvh3Sx6W HuU7a9iph8eVAbAX5UQ1y3nAEeAs+OvYwvegQFfhGEKUrChDUEJu5t6XaTP6RNESb0fe CGWuAoH22uPeEZLZR6rRau6dOlof4CMGkjAFUUXpOLux1Ii/WQCf0cyWzrpuI4EJqSla Cj2g== X-Gm-Message-State: AOJu0YwggsjMOoRKube1JDZyPum6ZjKwggMV8+HlzHJktT6m8lI+3AxE RfWabKl4lxWAlelVtWE63thxWg== X-Google-Smtp-Source: AGHT+IG/n51ocBB6FRywFFitnfbQeW9iCANzsfD18QE1l0UvN+OO0XnZsX2w3M7ClY3FnmZNCDy5EA== X-Received: by 2002:a05:6a00:14d6:b0:686:7621:5494 with SMTP id w22-20020a056a0014d600b0068676215494mr242443pfu.27.1691518912493; Tue, 08 Aug 2023 11:21:52 -0700 (PDT) Received: from google.com ([2620:15c:2d1:203:cc03:38d0:9718:e90b]) by smtp.gmail.com with ESMTPSA id j5-20020aa78d05000000b0065e154bac6dsm8365280pfe.133.2023.08.08.11.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 11:21:52 -0700 (PDT) Date: Tue, 8 Aug 2023 11:21:47 -0700 From: Nick Desaulniers To: Masahiro Yamada Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH v2 2/2] UML: use obj-y to descend into arch/um/*/ Message-ID: References: <20230721171857.3612639-1-masahiroy@kernel.org> <20230721171857.3612639-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721171857.3612639-2-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 22, 2023 at 02:18:57AM +0900, Masahiro Yamada wrote: > The single build rule does not work with the core-y syntax. [1] > > Use the standard obj-y syntax. > > [1]: https://lore.kernel.org/linux-kbuild/d57ba55f-20a3-b836-783d-b49c8a161b6e@kernel.org/T/#m7bc402e1e038f00ebcf2e92ed7fcb8a52fc1ea44 > > Signed-off-by: Masahiro Yamada This resolves an issue I reported (but doesn't seem to be on lore for linux-kbuild...) Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers > --- > > Changes in v2: > - Rephase the commit log > > arch/um/Kbuild | 2 ++ > arch/um/Makefile | 4 ---- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/um/Kbuild b/arch/um/Kbuild > index a4e40e534e6a..6cf0c1e5927b 100644 > --- a/arch/um/Kbuild > +++ b/arch/um/Kbuild > @@ -1 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > + > +obj-y += kernel/ drivers/ os-Linux/ > diff --git a/arch/um/Makefile b/arch/um/Makefile > index 1735a562453d..82f05f250634 100644 > --- a/arch/um/Makefile > +++ b/arch/um/Makefile > @@ -22,10 +22,6 @@ ARCH_DIR := arch/um > # features. > SHELL := /bin/bash > > -core-y += $(ARCH_DIR)/kernel/ \ > - $(ARCH_DIR)/drivers/ \ > - $(ARCH_DIR)/os-Linux/ > - > MODE_INCLUDE += -I$(srctree)/$(ARCH_DIR)/include/shared/skas > > HEADER_ARCH := $(SUBARCH) > -- > 2.39.2 >