From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C746DC04A6A for ; Wed, 9 Aug 2023 14:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233306AbjHIO3e (ORCPT ); Wed, 9 Aug 2023 10:29:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233302AbjHIO3d (ORCPT ); Wed, 9 Aug 2023 10:29:33 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3286B1FD7; Wed, 9 Aug 2023 07:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VsQpNZtjoKgsOWGOTa+TCccq2DgrQ3Hi+Jy0cIt7CSE=; b=SGt+RXuTmpITjw2x/CpmDR5Ai2 33bQyol969D2IgbgufuDyFBYb64UH5HQ6XxX5rIpLrd5ZMo0n38D/sh3PkiWC/GqTYLu6wSec4FIe uDXtiLimd8rYpUkUnVXfcK44XhknFev0WdlMnqcVHtCgtpDO8K5gD2mUziHu9C6lD6ziqMKvYztaY nwJCld1Sl+CqCsXCgDqOfC/art1f+wo2fi1H0wXkgcDA2ekFnOFOFqKjdquZ2F6amdxNLvHacxa2r 0vhZzF3GlzVgbC8ntYJMDi/vPMisbPU9dfGJDoqo1YK1tILToE8GCCFWwFVjqC6mq1KcWaWRMYgaY 3fThzPRg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60740) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qTkBd-0002dz-3D; Wed, 09 Aug 2023 15:29:22 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qTkBZ-0000ng-LV; Wed, 09 Aug 2023 15:29:17 +0100 Date: Wed, 9 Aug 2023 15:29:17 +0100 From: "Russell King (Oracle)" To: Ioana Ciornei Cc: Florian Fainelli , Jakub Kicinski , Andrew Lunn , Heiner Kallweit , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Ioana Ciornei , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandru Ardelean , Andre Edich , Antoine Tenart , Baruch Siach , Christophe Leroy , Divya Koppera , Hauke Mehrtens , Jerome Brunet , Kavya Sree Kotagiri , Linus Walleij , Marco Felsch , Marek Vasut , Martin Blumenstingl , Mathias Kresin , Maxim Kochetkov , Michael Walle , Neil Armstrong , Nisar Sayed , Oleksij Rempel , Philippe Schenker , Willy Liu , Yuiko Oshino Subject: Re: [PATCH] net: phy: Don't disable irqs on shutdown if WoL is enabled Message-ID: References: <20230804071757.383971-1-u.kleine-koenig@pengutronix.de> <20230808145325.343c5098@kernel.org> <1e438a02-6964-ce65-5584-e8ea57a694bb@gmail.com> <20230809142155.4dtmnmmecaycbtum@LXL00007.wbi.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809142155.4dtmnmmecaycbtum@LXL00007.wbi.nxp.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2023 at 05:21:55PM +0300, Ioana Ciornei wrote: > That's a perfect summary of the problem that I was trying to fix. > > The board in question is a LS1021ATSN which has two AR8031 PHYs that > share an interrupt line. In case only one of the PHYs is probed and > there are pending interrupts on the PHY#2 an IRQ storm will happen > since there is no entity to clear the interrupt from PHY#2's registers. > PHY#1's driver will get stuck in .handle_interrupt() indefinitely. So I have two further questions: 1. Is WoL able to be supported on this hardware? 2. AR8031 has a seperate WOL_INT signal that can be used to wake up the system. Is this used in the hardware design? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!