From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h
Date: Thu, 10 Aug 2023 16:29:25 +0300 [thread overview]
Message-ID: <ZNTmNW1I2aI6ervP@smile.fi.intel.com> (raw)
In-Reply-To: <d8f84ec0-142d-88d1-c317-acfb8c234bad@gmail.com>
On Wed, Aug 09, 2023 at 09:00:39AM +0300, Matti Vaittinen wrote:
> On 8/8/23 19:42, Andy Shevchenko wrote:
> > There is nothing from string_helpers.h used in the driver, correct
> > the header inclusion block accordingly.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
>
> Out of the curiosity - is the goal to get rid of including choices from
> helpers? (I think) then the header split would be more beneficial.
At the end, yes.
Thank you for acknowledging!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-10 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 16:42 [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h Andy Shevchenko
2023-08-09 6:00 ` Matti Vaittinen
2023-08-10 13:29 ` Andy Shevchenko [this message]
2023-08-28 17:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNTmNW1I2aI6ervP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox