* [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h
@ 2023-08-08 16:42 Andy Shevchenko
2023-08-09 6:00 ` Matti Vaittinen
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2023-08-08 16:42 UTC (permalink / raw)
To: Jonathan Cameron, Matti Vaittinen, linux-iio, linux-kernel
Cc: Jonathan Cameron, Lars-Peter Clausen, Andy Shevchenko
There is nothing from string_helpers.h used in the driver, correct
the header inclusion block accordingly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/accel/kionix-kx022a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c
index 4ea3c6718ed4..f164b09520c9 100644
--- a/drivers/iio/accel/kionix-kx022a.c
+++ b/drivers/iio/accel/kionix-kx022a.c
@@ -15,7 +15,7 @@
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
#include <linux/slab.h>
-#include <linux/string_helpers.h>
+#include <linux/string_choices.h>
#include <linux/units.h>
#include <linux/iio/iio.h>
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h
2023-08-08 16:42 [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h Andy Shevchenko
@ 2023-08-09 6:00 ` Matti Vaittinen
2023-08-10 13:29 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Matti Vaittinen @ 2023-08-09 6:00 UTC (permalink / raw)
To: Andy Shevchenko, Jonathan Cameron, linux-iio, linux-kernel
Cc: Jonathan Cameron, Lars-Peter Clausen
On 8/8/23 19:42, Andy Shevchenko wrote:
> There is nothing from string_helpers.h used in the driver, correct
> the header inclusion block accordingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
Out of the curiosity - is the goal to get rid of including choices from
helpers? (I think) then the header split would be more beneficial.
> ---
> drivers/iio/accel/kionix-kx022a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c
> index 4ea3c6718ed4..f164b09520c9 100644
> --- a/drivers/iio/accel/kionix-kx022a.c
> +++ b/drivers/iio/accel/kionix-kx022a.c
> @@ -15,7 +15,7 @@
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> #include <linux/slab.h>
> -#include <linux/string_helpers.h>
> +#include <linux/string_choices.h>
> #include <linux/units.h>
>
> #include <linux/iio/iio.h>
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h
2023-08-09 6:00 ` Matti Vaittinen
@ 2023-08-10 13:29 ` Andy Shevchenko
2023-08-28 17:35 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2023-08-10 13:29 UTC (permalink / raw)
To: Matti Vaittinen
Cc: Jonathan Cameron, linux-iio, linux-kernel, Jonathan Cameron,
Lars-Peter Clausen
On Wed, Aug 09, 2023 at 09:00:39AM +0300, Matti Vaittinen wrote:
> On 8/8/23 19:42, Andy Shevchenko wrote:
> > There is nothing from string_helpers.h used in the driver, correct
> > the header inclusion block accordingly.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
>
> Out of the curiosity - is the goal to get rid of including choices from
> helpers? (I think) then the header split would be more beneficial.
At the end, yes.
Thank you for acknowledging!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h
2023-08-10 13:29 ` Andy Shevchenko
@ 2023-08-28 17:35 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-08-28 17:35 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Matti Vaittinen, Jonathan Cameron, linux-iio, linux-kernel,
Lars-Peter Clausen
On Thu, 10 Aug 2023 16:29:25 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Aug 09, 2023 at 09:00:39AM +0300, Matti Vaittinen wrote:
> > On 8/8/23 19:42, Andy Shevchenko wrote:
> > > There is nothing from string_helpers.h used in the driver, correct
> > > the header inclusion block accordingly.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
> >
> > Out of the curiosity - is the goal to get rid of including choices from
> > helpers? (I think) then the header split would be more beneficial.
>
> At the end, yes.
>
> Thank you for acknowledging!
>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-28 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 16:42 [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h Andy Shevchenko
2023-08-09 6:00 ` Matti Vaittinen
2023-08-10 13:29 ` Andy Shevchenko
2023-08-28 17:35 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox