From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v2 2/6] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set()
Date: Fri, 11 Aug 2023 12:25:02 +0300 [thread overview]
Message-ID: <ZNX+bponlicM3AFL@smile.fi.intel.com> (raw)
In-Reply-To: <20230811005732.107718-3-yury.norov@gmail.com>
On Thu, Aug 10, 2023 at 05:57:28PM -0700, Yury Norov wrote:
> _reg_op(REG_OP_ALLOC) duplicates bitmap_set(). Fix it.
...
> int bitmap_allocate_region(unsigned long *bitmap, unsigned int pos, int order)
> {
> + unsigned int nbits = pos + BIT(order);
Shouldn't this be unsigned long?
As the prototype of the used later unsigned long find_next_bit().
> if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
> return -EBUSY;
> - return __reg_op(bitmap, pos, order, REG_OP_ALLOC);
> + bitmap_set(bitmap, pos, nbits);
> + return 0;
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-11 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 0:57 [PATCH v2 0/6] bitmap: cleanup bitmap_*_region() implementation Yury Norov
2023-08-11 0:57 ` [PATCH v2 1/6] bitmap: fix opencoded bitmap_allocate_region() Yury Norov
2023-08-11 0:57 ` [PATCH v2 2/6] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() Yury Norov
2023-08-11 6:21 ` Rasmus Villemoes
2023-08-11 12:56 ` Yury Norov
2023-08-11 13:31 ` Rasmus Villemoes
2023-08-14 0:39 ` Yury Norov
2023-08-11 9:25 ` Andy Shevchenko [this message]
2023-08-11 13:01 ` Yury Norov
2023-08-11 0:57 ` [PATCH v2 3/6] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear() Yury Norov
2023-08-11 0:57 ` [PATCH v2 4/6] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit() Yury Norov
2023-08-11 0:57 ` [PATCH v2 5/6] bitmap: drop _reg_op() function Yury Norov
2023-08-11 0:57 ` [PATCH v2 6/6] bitmap: move bitmap_*_region functions to bitmap.h Yury Norov
2023-08-11 9:27 ` Andy Shevchenko
2023-08-11 13:05 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNX+bponlicM3AFL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox