From: William Breathitt Gray <william.gray@linaro.org>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Paul Demetrotion <pdemetrotion@winsystems.com>
Subject: Re: [RESEND PATCH 7/7] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent
Date: Fri, 11 Aug 2023 07:23:03 -0400 [thread overview]
Message-ID: <ZNYaF0bghMQp4+Pl@fedora> (raw)
In-Reply-To: <ZNX9Oo2AOASHKOPZ@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
On Fri, Aug 11, 2023 at 12:19:54PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 10, 2023 at 06:00:44PM -0400, William Breathitt Gray wrote:
> > The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA,
> > which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the
> > correct value of 11 so that access to necessary device registers is
> > properly requested in the ws16c48_probe() callback by the
> > devm_request_region() function call.
> >
> > Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
>
> Fixes should go first in the series, but I see no conflict here, I hope Bart
> can manage this when applying.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> --
> With Best Regards,
> Andy Shevchenko
Bart, if you encounter any issues reordering this patch first before the
others, just let me know and I'll send a rebased version with the
appropriate context adjustments.
Thanks,
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-11 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 22:00 [RESEND PATCH 0/7] Migrate ACCES and WinSystems drivers to the regmap API William Breathitt Gray
2023-08-10 22:00 ` [RESEND PATCH 1/7] gpio: idio-16: Migrate " William Breathitt Gray
2023-08-10 22:00 ` [RESEND PATCH 2/7] gpio: 104-idio-16: " William Breathitt Gray
2023-08-10 22:00 ` [RESEND PATCH 3/7] gpio: pci-idio-16: " William Breathitt Gray
2023-08-10 22:00 ` [RESEND PATCH 4/7] gpio: idio-16: Remove unused legacy interface William Breathitt Gray
2023-08-10 22:00 ` [RESEND PATCH 5/7] gpio: pcie-idio-24: Migrate to the regmap API William Breathitt Gray
2023-08-10 22:00 ` [RESEND PATCH 6/7] gpio: ws16c48: " William Breathitt Gray
2023-08-10 22:00 ` [RESEND PATCH 7/7] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent William Breathitt Gray
2023-08-11 9:19 ` Andy Shevchenko
2023-08-11 11:23 ` William Breathitt Gray [this message]
2023-08-11 9:32 ` [RESEND PATCH 0/7] Migrate ACCES and WinSystems drivers to the regmap API Linus Walleij
2023-08-11 12:24 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNYaF0bghMQp4+Pl@fedora \
--to=william.gray@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdemetrotion@winsystems.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox