From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F7CC001E0 for ; Sun, 13 Aug 2023 16:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbjHMQak (ORCPT ); Sun, 13 Aug 2023 12:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231679AbjHMQaf (ORCPT ); Sun, 13 Aug 2023 12:30:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90A68270C; Sun, 13 Aug 2023 09:30:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD76A63E4C; Sun, 13 Aug 2023 16:30:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 772E0C433C7; Sun, 13 Aug 2023 16:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691944211; bh=k/DBSLeuTDT5ffAyIQgS9LkNXlXka5DsrXBly3EUM0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LFQxSkVPvVNMY5UGkTgEyjqDjqrB49JwReYXKnsxLTmIytnyOC5Ivrm5bumPDj79S MrikeE1aFQxDkFQe1kVJ/+07ZhzCDiOkBDfqo/61gIqGiubQiqUP58XpxzbhespKlm B1xHwCRETs+nH4YDTfs45b/adRiPbJNurMxwmYd3xEg8wSHna1y9Yc692MgvWNvXHu bLYi0ygSqCg1UvXQniVEKnWwb7NAouzpXrvq2a3mXgj9u/bHhtTlJCgSWC2n9EbWTi V0h56gbG8V2PxbpIPCwTqh54dOr6O82h487xNMQYbyVbUyWKZFi9ZkMRV+uLJt7OjD +MULKkHfQW09g== Date: Sun, 13 Aug 2023 18:30:06 +0200 From: Simon Horman To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Krishnanand Prabhu , Luca Coelho , Gregory Greenman , Johannes Berg , Kalle Valo , linux-wireless@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Richard Cochran Subject: Re: [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock Message-ID: References: <20230812052947.22913-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230812052947.22913-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Richard Cochran On Fri, Aug 11, 2023 at 10:29:47PM -0700, Randy Dunlap wrote: > When the code to use the PTP HW clock was added, it didn't update > the Kconfig entry for the PTP dependency, leading to build errors, > so update the Kconfig entry to depend on PTP_1588_CLOCK_OPTIONAL. > > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_init': > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294: undefined reference to `ptp_clock_register' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294:(.text+0xce8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register' > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301: undefined reference to `ptp_clock_index' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301:(.text+0xd18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index' > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_remove': > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315: undefined reference to `ptp_clock_index' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315:(.text+0xe80): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index' > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319: undefined reference to `ptp_clock_unregister' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319:(.text+0xeac): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_unregister' > > Fixes: 1595ecce1cf3 ("wifi: iwlwifi: mvm: add support for PTP HW clock (PHC)") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Link: https://lore.kernel.org/all/202308110447.4QSJHmFH-lkp@intel.com/ > Cc: Krishnanand Prabhu > Cc: Luca Coelho > Cc: Gregory Greenman > Cc: Johannes Berg > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested > --- > drivers/net/wireless/intel/iwlwifi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig > --- a/drivers/net/wireless/intel/iwlwifi/Kconfig > +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig > @@ -66,6 +66,7 @@ config IWLMVM > tristate "Intel Wireless WiFi MVM Firmware support" > select WANT_DEV_COREDUMP > depends on MAC80211 > + depends on PTP_1588_CLOCK_OPTIONAL > help > This is the driver that supports the MVM firmware. The list > of the devices that use this firmware is available here: >