From: Artem Chernyshev <artem.chernyshev@red-soft.ru>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Arend van Spriel <aspriel@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] brcm80211: brcmsmac: phy_cmn: Remove unreachable code
Date: Mon, 14 Aug 2023 10:24:00 +0300 [thread overview]
Message-ID: <ZNnWkD5pCTAD7jTc@localhost.localdomain> (raw)
In-Reply-To: <CAOiHx==NiPG2GdZNrJn5hPEdi70Spe9Kc9CHO5NjnATAjCgUsg@mail.gmail.com>
On Mon, Aug 14, 2023 at 09:19:14AM +0200, Jonas Gorski wrote:
> On Sun, 13 Aug 2023 at 23:31, Artem Chernyshev
> <artem.chernyshev@red-soft.ru> wrote:
> >
> > Since wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy()
> > can not return false it's impossible to get true value in this
> > if statement
>
> If they can only return true, then maybe their return types should be
> changed to void as well? No point in returning a value when the only
> caller is ignoring it.
>
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
>
> Regards,
> Jonas
True that. I'll make those changes in v2.
Thank you,
Artem
next prev parent reply other threads:[~2023-08-14 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 21:23 [PATCH] brcm80211: brcmsmac: phy_cmn: Remove unreachable code Artem Chernyshev
2023-08-14 7:19 ` Jonas Gorski
2023-08-14 7:24 ` Artem Chernyshev [this message]
2023-08-14 9:36 ` [PATCH v2] brcm80211: brcmsmac: phy: " Artem Chernyshev
2023-08-25 8:34 ` Jonas Gorski
2024-01-18 13:05 ` [v2] wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNnWkD5pCTAD7jTc@localhost.localdomain \
--to=artem.chernyshev@red-soft.ru \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox