From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96234C41513 for ; Mon, 14 Aug 2023 17:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbjHNRUw (ORCPT ); Mon, 14 Aug 2023 13:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbjHNRUs (ORCPT ); Mon, 14 Aug 2023 13:20:48 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E65210C1 for ; Mon, 14 Aug 2023 10:20:48 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-686c06b8011so5125541b3a.2 for ; Mon, 14 Aug 2023 10:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692033648; x=1692638448; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Hb60I+by4IYJ2RvslpchrA01TfAlxGb3Z0+HBOXiSTM=; b=pc+bbMTD1I5N3vZCfumM2t4nBCGZMoSKh1EZd+s47/QBV6vLHyfZp+yPg+iVHrgERE HyAwzkXN+/tiLqI93mIN41Wn6Tru4HSW/8uLarQRuFGJ+uVhv+EJFgKTxo9/TTXVQ/9y RYvMgZoLzBSRxl0VVK+UUQgKR3fKe+zRdvSS1ZQSqfLxzLjwoS4CUSCRqCPSaLO1tt26 7isneEyU61tcxyvg9QIE2rqY5UI0/eRciGyEi/0nv6w15Ke6usVMYFOoPOB+92FQlZRN BITs220K+iiyRXjekNRUEzTTxsV263YYq7XNvmoGShahRVANJSZmRqI/ktQ4Z9SIkiew SQ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692033648; x=1692638448; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hb60I+by4IYJ2RvslpchrA01TfAlxGb3Z0+HBOXiSTM=; b=b6zTBmFJFjjHS7Txns8ko7NN8ZRZeMopCFdGSoUzgv7YsPMkFgWrCBMEy/GkuwpD47 ndm2yPbZ2Nd1Y9fzsxdePiyn1eYqUQqv6GkFcXoofeDNVYTc90WDco76QBXZEEvlEzTu LxBTYu2h8YUHn4b+kumzzPmgSWUP4bRt2bMSi8YJNLKxhovJzPtwq0tSg8AE26cwfPJr p3/uwpTvV0A/g8ahr54h6kkkARiATh9jTfBEndFKSzkFL6sH0fUSIhMCo43HMeAOcEop R86ftaErH5loxLwkN4xWGA5dR3ybfgXBf3ml4HVuYjLbrxyQqbIvNGBVTq7Dxvi6QEdG flrQ== X-Gm-Message-State: AOJu0YyYYCKoPJzXgV7PLqjyoRI8zut70RL3Dr0M+pBHm+zGtckR8NgS HMaOTUcX40pb+uBwqUm2LAL9TZ8KZxQ= X-Google-Smtp-Source: AGHT+IGQ08GfI1AHFkD/9MYPa37qaV6H9DwO3VplFWWx/OqI1SEMkNX8PtGisP5vPTSri9S6IrzNu9rT9wE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:2313:b0:687:3110:7faa with SMTP id h19-20020a056a00231300b0068731107faamr4235606pfh.5.1692033647805; Mon, 14 Aug 2023 10:20:47 -0700 (PDT) Date: Mon, 14 Aug 2023 10:20:40 -0700 In-Reply-To: <82ba1020-bfbe-dcab-1d8c-961f30c7bf12@intel.com> Mime-Version: 1.0 References: <20230729011608.1065019-1-seanjc@google.com> <20230729011608.1065019-8-seanjc@google.com> <82ba1020-bfbe-dcab-1d8c-961f30c7bf12@intel.com> Message-ID: Subject: Re: [PATCH v2 07/21] KVM: x86: Add a framework for enabling KVM-governed x86 features From: Sean Christopherson To: Zeng Guang Cc: Paolo Bonzini , Vitaly Kuznetsov , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Maxim Levitsky Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023, Zeng Guang wrote: > > On 7/29/2023 9:15 AM, Sean Christopherson wrote: > > +static __always_inline int kvm_governed_feature_index(unsigned int x86_feature) > > +{ > > + switch (x86_feature) { > > +#define KVM_GOVERNED_FEATURE(x) case x: return KVM_GOVERNED_##x; > > +#include "governed_features.h" > > + default: > > + return -1; > > + } > > +} > > + > > +static __always_inline int kvm_is_governed_feature(unsigned int x86_feature) > > +{ > > + return kvm_governed_feature_index(x86_feature) >= 0; > > +} > > + > > I think it proper to return a bool, not "int" instead. Yeah. I'm pretty sure someone brought this up in v1 too, and I spaced on it.