From: Jason Gunthorpe <jgg@ziepe.ca>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: kvm@vger.kernel.org, "Tian, Kevin" <kevin.tian@intel.com>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 1/4] vfio: trivially use __aligned_u64 for ioctl structs
Date: Mon, 14 Aug 2023 14:47:23 -0300 [thread overview]
Message-ID: <ZNpoq7emI19fApND@ziepe.ca> (raw)
In-Reply-To: <20230809210248.2898981-2-stefanha@redhat.com>
On Wed, Aug 09, 2023 at 05:02:45PM -0400, Stefan Hajnoczi wrote:
> u64 alignment behaves differently depending on the architecture and so
> <uapi/linux/types.h> offers __aligned_u64 to achieve consistent behavior
> in kernel<->userspace ABIs.
>
> There are structs in <uapi/linux/vfio.h> that can trivially be updated
> to __aligned_u64 because the struct sizes are multiples of 8 bytes.
> There is no change in memory layout on any CPU architecture and
> therefore this change is safe.
>
> The commits that follow this one handle the trickier cases where
> explanation about ABI breakage is necessary.
>
> Suggested-by: Jason Gunthorpe <jgg@ziepe.ca>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> include/uapi/linux/vfio.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2023-08-14 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 21:02 [PATCH 0/4] vfio: use __aligned_u64 for ioctl structs Stefan Hajnoczi
2023-08-09 21:02 ` [PATCH 1/4] vfio: trivially " Stefan Hajnoczi
2023-08-14 17:47 ` Jason Gunthorpe [this message]
2023-08-09 21:02 ` [PATCH 2/4] vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info Stefan Hajnoczi
2023-08-10 3:22 ` Tian, Kevin
2023-08-10 14:24 ` Stefan Hajnoczi
2023-08-15 12:38 ` Stefan Hajnoczi
2023-08-14 17:50 ` Jason Gunthorpe
2023-08-15 12:38 ` Stefan Hajnoczi
2023-08-15 15:23 ` David Laight
2023-08-16 13:36 ` Stefan Hajnoczi
2023-08-09 21:02 ` [PATCH 3/4] vfio: use __aligned_u64 in struct vfio_iommu_type1_info Stefan Hajnoczi
2023-08-10 3:25 ` Tian, Kevin
2023-08-10 14:25 ` Stefan Hajnoczi
2023-08-14 17:52 ` Jason Gunthorpe
2023-08-09 21:02 ` [PATCH 4/4] vfio: use __aligned_u64 in struct vfio_device_ioeventfd Stefan Hajnoczi
2023-08-14 17:52 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNpoq7emI19fApND@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox