From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D112C41513 for ; Mon, 14 Aug 2023 23:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232580AbjHNX57 (ORCPT ); Mon, 14 Aug 2023 19:57:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232979AbjHNX5l (ORCPT ); Mon, 14 Aug 2023 19:57:41 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C51091738 for ; Mon, 14 Aug 2023 16:57:38 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2F74F5C0091; Mon, 14 Aug 2023 19:57:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 14 Aug 2023 19:57:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= joshtriplett.org; h=cc:cc:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1692057458; x=1692143858; bh=RkOWZYvREjVZVSchqVarX+O9HxVq93B/IRy UEDOrIG0=; b=nA6FhDu90vR4Kz4+mCApwVtm/g2R0FYrbPaYKfJ1iXLwAJQ/aBF BYvKTlFJOxCjkuLt/Z4jK0TzPffib5MYc5FdgQcHXFk0fXEUEfhoYb+gL/93Eqsb Y3yjum6dEV9BM37SzGZ+7/VODnZdsRFzGsVCLq/FHqdybOMjP2wP1KmsCkIDTmMs nmcwNMAfFqB5Mvo3FKUjYqLYDImHF4aJIMeIBabWL75Q5oCIfJWJcDFH/mPEyW3W VnTqBKS5BV6GTFCf0nU1lkHislnRxpFvlbzT3H2bC+f1CXu1/Udqn6a8iGkkBv3a TZv0sVsC30oOpMvW60aMmtVAnvmZEYduLNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1692057458; x=1692143858; bh=RkOWZYvREjVZV SchqVarX+O9HxVq93B/IRyUEDOrIG0=; b=E0T7d+FtjQzJf3fJOrPgxTbunDc5j DwmbRTOGw8bXXVxYvRftqUHS2msi+pfs7GAmUgfsnQ41mhC93Ct876ypmxp0guHX R53OEoLLp0bJrtTCm9tNhN7fSPthaK9cjZbtiKmD36wbDNNkahjthrHarhu4o19t As1pjkTWgyIBDXXb0KdbyOcrvti7yFy+BnLHAuGAQvO7R+GdRvd7HlELmCci7Rgo wqzXLFA2E8JbVxXatYW3bncGpdaHaEGS8t/M/7Y6XiK/5pIcfAJw0d9J0bsBfOd/ rBkks25mUw8LthGqceUCInmYXGlIWBNkWOqTYadXRUWKQXz3Lql6y6VZw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtiedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheplfhoshhh ucfvrhhiphhlvghtthcuoehjohhshhesjhhoshhhthhrihhplhgvthhtrdhorhhgqeenuc ggtffrrghtthgvrhhnpeduieegheeijeeuvdetudefvedtjeefgeeufefghfekgfelfeet teelvddtffetgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehjohhshhesjhhoshhhthhrihhplhgvthhtrdhorhhg X-ME-Proxy: Feedback-ID: i83e94755:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Aug 2023 19:57:32 -0400 (EDT) Date: Mon, 14 Aug 2023 16:57:30 -0700 From: Josh Triplett To: Borislav Petkov Cc: Thomas Gleixner , LKML , x86@kernel.org, Ashok Raj , Arjan van de Ven , Nikolay Borisov Subject: Re: [patch V2 02/37] x86/microcode: Hide the config knob Message-ID: References: <20230812194003.682298127@linutronix.de> <20230812195727.660453052@linutronix.de> <20230814211912.GMZNqaUD6FriYo1wOo@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814211912.GMZNqaUD6FriYo1wOo@fat_crate.local> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023 at 11:19:12PM +0200, Borislav Petkov wrote: > On Mon, Aug 14, 2023 at 02:01:03PM -0700, Josh Triplett wrote: > > I'd be happy to help keep this case building. Would you consider > > accepting a patch atop this series re-introducing minimal support for > > disabling this? > > And a couple more KBs of builtin code is a problem because? Multiple reasons. First, because "a couple more KBs" (concretely, 4637 bytes in this case) add up across the kernel. Second, because disabling something is the easiest way to guarantee spending *zero* boot time on it. And third, because I just confirmed that this requires a *trivial* patch to support (apart from re-enabling the config option): --- a/arch/x86/include/asm/microcode.h +++ b/arch/x86/include/asm/microcode.h @@ -68,11 +68,12 @@ static inline u32 intel_get_microcode_revision(void) return rev; } +#endif /* CONFIG_CPU_SUP_INTEL */ +#if defined(CONFIG_MICROCODE) && defined(CONFIG_CPU_SUP_INTEL) void show_ucode_info_early(void); - -#else /* CONFIG_CPU_SUP_INTEL */ +#else static inline void show_ucode_info_early(void) { } -#endif /* !CONFIG_CPU_SUP_INTEL */ +#endif #endif /* _ASM_X86_MICROCODE_H */