Re: [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

Mukesh Ojha
2023-03-06T12:52:25Z

On 3/6/2023 5:55 PM, Douglas RAILLARD wrote:
> From: Douglas Raillard <douglas.raillard@arm.com>
>
> Fix the nid_t field so that its size is correctly reported in the text
> format embedded in trace.dat files. As it stands, it is reported as
> being of size 4:
>
> field:nid_t nid[3]; offset:24; size:4; signed:0;
>
> Instead of 12:
>
> field:nid_t nid[3]; offset:24; size:12; signed:0;
>
> This also fixes the reported offset of subsequent fields so that they
> match with the actual struct layout.
>
>
> Signed-off-by: Douglas Raillard <douglas.raillard@arm.com>
> ---
> include/trace/events/f2fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index 31d994e6b4ca..8d053838d6cf 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -512,7 +512,7 @@ TRACE_EVENT(f2fs_truncate_partial_nodes,
> TP_STRUCT__entry(
> __field(dev_t, dev)
> __field(ino_t, ino)
> - __field(nid_t, nid[3])
> + __array(nid_t, nid, 3)

Good catch.

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> __field(int, depth)
> __field(int, err)
> ),