[PATCH v2 0/1] workqueue: Rename rescuer kworker

[PATCH v2 0/1] workqueue: Rename rescuer kworker

[Aaron Tomlin]

Each CPU-specific and unbound kworker kthread conforms to a particular
naming scheme. However, this does not extend to the rescuer kworker.
At present, a rescuer kworker is simply named according to its
workqueue's name. This can be cryptic.

This patch modifies a rescuer to follow the kworker naming scheme.
The "r" is indicative of a rescuer and after "-" is its workqueue's
name e.g. "kworker/r-ext4-rsv-conver".

--
Changes since v1 [1]:
 - Remove CPU affinity comment about the kworker (Tejun Heo)

[1]: https://lore.kernel.org/lkml/ZNFxmnGHxV0z5gKA@slm.duckdns.org/
--

Aaron Tomlin (1):
  workqueue: Rename rescuer kworker

 kernel/workqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.39.1

[PATCH v2 1/1] workqueue: Rename rescuer kworker

[Aaron Tomlin]

Each CPU-specific and unbound kworker kthread conforms to a particular
naming scheme. However, this does not extend to the rescuer kworker.
At present, a rescuer kworker is simply named according to its
workqueue's name. This can be cryptic.

This patch modifies a rescuer to follow the kworker naming scheme.
The "r" is indicative of a rescuer and after "-" is its workqueue's
name e.g. "kworker/r-ext4-rsv-conver".

Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
---
 kernel/workqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 02a8f402eeb5..d9bb375b8d02 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4599,7 +4599,7 @@ static int init_rescuer(struct workqueue_struct *wq)
 	}
 
 	rescuer->rescue_wq = wq;
-	rescuer->task = kthread_create(rescuer_thread, rescuer, "%s", wq->name);
+	rescuer->task = kthread_create(rescuer_thread, rescuer, "kworker/r-%s", wq->name);
 	if (IS_ERR(rescuer->task)) {
 		ret = PTR_ERR(rescuer->task);
 		pr_err("workqueue: Failed to create a rescuer kthread for wq \"%s\": %pe",
-- 
2.39.1

Re: [PATCH v2 1/1] workqueue: Rename rescuer kworker

[Tejun Heo]

On Tue, Aug 08, 2023 at 01:03:29PM +0100, Aaron Tomlin wrote:
> Each CPU-specific and unbound kworker kthread conforms to a particular
> naming scheme. However, this does not extend to the rescuer kworker.
> At present, a rescuer kworker is simply named according to its
> workqueue's name. This can be cryptic.
> 
> This patch modifies a rescuer to follow the kworker naming scheme.
> The "r" is indicative of a rescuer and after "-" is its workqueue's
> name e.g. "kworker/r-ext4-rsv-conver".
> 
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>

Applied to wq/for-6.6 with prefix "r" replaced with "R" to make it more
distinct and consistent with how highpri pools are marked.

Thanks.

-- 
tejun

Re: [PATCH v2 1/1] workqueue: Rename rescuer kworker

[Aaron Tomlin]

> Applied to wq/for-6.6 with prefix "r" replaced with "R" to make it more
> distinct and consistent with how highpri pools are marked.

Hi Tejun,

Thank you.


Kind regards,
-- 
Aaron Tomlin