From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim()
Date: Tue, 15 Aug 2023 13:34:12 +0300 [thread overview]
Message-ID: <ZNtUpMe41HEztHLw@smile.fi.intel.com> (raw)
In-Reply-To: <20230812185748.5799-1-brgl@bgdev.pl>
On Sat, Aug 12, 2023 at 08:57:48PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Turns out we can avoid the memmove() by using skip_spaces() and strim().
> We did that in gpio-consumer, let's do it in gpio-sim.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> + strim(trimmed);
>
> - return dup;
> + return trimmed;
Can be also
return strim(trimmed);
If it's only about \n replacement, then
return strreplace(trimmed, '\n', '\0');
would work and in the next release be changed to kstrdup_and_replace().
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-15 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 18:57 [PATCH] gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim() Bartosz Golaszewski
2023-08-15 10:34 ` Andy Shevchenko [this message]
2023-08-15 18:45 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNtUpMe41HEztHLw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox