From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22050C41513 for ; Tue, 15 Aug 2023 11:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235602AbjHOLZM (ORCPT ); Tue, 15 Aug 2023 07:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235300AbjHOLYz (ORCPT ); Tue, 15 Aug 2023 07:24:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 014EF10C1; Tue, 15 Aug 2023 04:24:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BB10654B2; Tue, 15 Aug 2023 11:24:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6EA2C433C7; Tue, 15 Aug 2023 11:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692098692; bh=Q5TrKurT2V4yZHymYHBHdElu209s20+L7p37ce3WGpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iQz+eCpoiW8g1C6M+rjd5bNTCcQCAKddvMg/GlDo8Cc/Zf7VyP5jG9CyKx+RqBelL T5bli702r9gFFmKeCQyWug510u9V6P6UopxvESg082ZoNIDOMW4dpsZ7htA5RNch+Y htVCwNbMf3s8hpmgnd5YiKJXiE6LFoU5XX9ifZSytD5/NbGJfemgDhaCJaYhdCAhKB p7xQ2z1oxoNTpFMmc9Niuuhg2Rk72EcS+mfYyWQTBu7ahdOlg9/CJBDLcFBglr3Mnw U/dpU3LEIT1tSyf69rTPU2oqLMy1VNdVp98/8JOpqVJzF5W0XGW9uJh88gk0K9QQ51 et+KKjvuQFeZw== Date: Tue, 15 Aug 2023 13:24:47 +0200 From: Simon Horman To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Bianconi , Alexander Duyck , Liang Chen , Alexander Lobakin , Saeed Mahameed , Leon Romanovsky , Eric Dumazet , Jesper Dangaard Brouer , Ilias Apalodimas , linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next v6 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA Message-ID: References: <20230814125643.59334-1-linyunsheng@huawei.com> <20230814125643.59334-2-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814125643.59334-2-linyunsheng@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023 at 08:56:38PM +0800, Yunsheng Lin wrote: ... > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 77cb75e63aca..d62c11aaea9a 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c ... > @@ -737,18 +736,16 @@ static void page_pool_free_frag(struct page_pool *pool) > page_pool_return_page(pool, page); > } > > -struct page *page_pool_alloc_frag(struct page_pool *pool, > - unsigned int *offset, > - unsigned int size, gfp_t gfp) > +struct page *__page_pool_alloc_frag(struct page_pool *pool, > + unsigned int *offset, > + unsigned int size, gfp_t gfp) > { > unsigned int max_size = PAGE_SIZE << pool->p.order; > struct page *page = pool->frag_page; > > - if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG) || > - size > max_size)) > + if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG)) Hi Yunsheng Lin, There is a ')' missing on the line above, which results in a build failure. > return NULL; > > - size = ALIGN(size, dma_get_cache_alignment()); > *offset = pool->frag_offset; > > if (page && *offset + size > max_size) { > @@ -781,7 +778,7 @@ struct page *page_pool_alloc_frag(struct page_pool *pool, > alloc_stat_inc(pool, fast); > return page; > } > -EXPORT_SYMBOL(page_pool_alloc_frag); > +EXPORT_SYMBOL(__page_pool_alloc_frag); > > static void page_pool_empty_ring(struct page_pool *pool) > { -- pw-bot: changes-requested