From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/25] ALSA: korg1212: Convert to generic PCM copy ops
Date: Tue, 15 Aug 2023 16:55:06 +0300 [thread overview]
Message-ID: <ZNuDugkvHrh7J/fF@smile.fi.intel.com> (raw)
In-Reply-To: <20230814115523.15279-9-tiwai@suse.de>
On Mon, Aug 14, 2023 at 01:55:06PM +0200, Takashi Iwai wrote:
> This patch converts the korg1212 driver code to use the new unified
> PCM copy callback. The open-coded conditional memory copies are
> replaced with simpler copy_from/to_iter() calls.
>
> Note that copy_from/to_iter() returns the copied bytes, hence the
> error condition is inverted from copy_from/to_user().
...
> + if (!copy_to_iter(src, size, dst))
!= size ?
> return -EFAULT;
...
> + if (!copy_from_iter(dst, size, src))
> return -EFAULT;
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-15 13:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 11:54 [PATCH 00/25] ALSA: Generic PCM copy ops using iov_iter Takashi Iwai
2023-08-14 11:54 ` [PATCH 01/25] iov_iter: Export import_ubuf() Takashi Iwai
2023-08-14 11:55 ` [PATCH 02/25] ALSA: pcm: Add copy ops with iov_iter Takashi Iwai
2023-08-14 11:55 ` [PATCH 03/25] ALSA: core: Add memory copy helpers between iov_iter and iomem Takashi Iwai
2023-08-15 13:51 ` Andy Shevchenko
2023-08-15 13:54 ` Takashi Iwai
2023-08-14 11:55 ` [PATCH 04/25] ALSA: dummy: Convert to generic PCM copy ops Takashi Iwai
2023-08-15 13:52 ` Andy Shevchenko
2023-08-14 11:55 ` [PATCH 05/25] ALSA: gus: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 06/25] ALSA: emu8000: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 07/25] ALSA: es1938: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 08/25] ALSA: korg1212: " Takashi Iwai
2023-08-15 13:55 ` Andy Shevchenko [this message]
2023-08-14 11:55 ` [PATCH 09/25] ALSA: nm256: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 10/25] ALSA: rme32: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 11/25] ALSA: rme96: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 12/25] ALSA: hdsp: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 13/25] ALSA: rme9652: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 14/25] ALSA: sh: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 15/25] ALSA: xen: " Takashi Iwai
2023-08-14 11:55 ` [PATCH 16/25] ALSA: pcmtest: Update comment about " Takashi Iwai
2023-08-14 11:55 ` [PATCH 17/25] media: solo6x10: Convert to generic " Takashi Iwai
2023-08-14 12:15 ` Ismael Luceno
2023-08-14 12:17 ` Takashi Iwai
2023-08-14 12:26 ` Ismael Luceno
2023-08-14 11:55 ` [PATCH 18/25] ASoC: component: Add " Takashi Iwai
2023-08-14 12:59 ` Mark Brown
2023-08-15 13:56 ` Andy Shevchenko
2023-08-14 11:55 ` [PATCH 19/25] ASoC: mediatek: Convert to " Takashi Iwai
2023-08-14 13:00 ` Mark Brown
2023-08-15 13:58 ` Andy Shevchenko
2023-08-14 11:55 ` [PATCH 20/25] ASoC: qcom: " Takashi Iwai
2023-08-14 13:06 ` Mark Brown
2023-08-14 11:55 ` [PATCH 21/25] ASoC: dmaengine: " Takashi Iwai
2023-08-14 13:18 ` Mark Brown
2023-08-15 14:00 ` Andy Shevchenko
2023-08-15 14:55 ` Takashi Iwai
2023-08-15 15:45 ` Andy Shevchenko
2023-08-14 11:55 ` [PATCH 22/25] ASoC: dmaengine: Use iov_iter for process callback, too Takashi Iwai
2023-08-14 13:19 ` Mark Brown
2023-08-14 11:55 ` [PATCH 23/25] ALSA: doc: Update description for the new PCM copy ops Takashi Iwai
2023-08-14 11:55 ` [PATCH 24/25] ASoC: pcm: Drop obsoleted PCM copy_user ops Takashi Iwai
2023-08-14 13:19 ` Mark Brown
2023-08-14 11:55 ` [PATCH 25/25] ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel ops Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNuDugkvHrh7J/fF@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox