From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFD6C04A6A for ; Tue, 15 Aug 2023 14:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237782AbjHOOyB (ORCPT ); Tue, 15 Aug 2023 10:54:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237783AbjHOOx7 (ORCPT ); Tue, 15 Aug 2023 10:53:59 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BF7DE5B; Tue, 15 Aug 2023 07:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692111239; x=1723647239; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8cZYt7HFAnk2MmSwXTT2RjgwpBr32yZmczsS440Qatw=; b=Vv7sNR3/duZXS1dd7e7sSt9EfIfKffR5uw0GNL3gw5J6EL0o6e06KBNh Vy3ZmMwMd/YIGx/0vPPKWqoGnKtiCbyxldkElDvGHyJ8yj5lh1WOi3o/6 zIlblfbtGUeKKizPiap8yKaSyEzkGJ0Cs/5WwGKXLzLywvBBCzalvtBaw pTDJtT55X43tQmruEmmThMreQE8FevHaalzMMua6UMzhUn3RS7t0LGj4n atADgBfdHi1zVk0bh2kA/fmo5m4HohKGGOQq51hUeUz/gAdsIFVBqNwM0 KGD1qOthzNBpeLE5ZD8G0QhYflK50aohws1EeYCGLzUAa/Q05xGPpWMcI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="371207049" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="371207049" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 07:53:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="907630159" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="907630159" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 15 Aug 2023 07:53:53 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qVvQd-0065qi-2C; Tue, 15 Aug 2023 17:53:51 +0300 Date: Tue, 15 Aug 2023 17:53:51 +0300 From: Andy Shevchenko To: Marcus Folkesson Cc: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cosmin Tanislav , Arnd Bergmann , ChiYuan Huang , Haibo Chen , Ramona Bolboaca , Ibrahim Tilki , ChiaEn Wu , William Breathitt Gray , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/6] iio: adc: mcp3911: simplify usage of spi->dev Message-ID: References: <20230814121010.184842-1-marcus.folkesson@gmail.com> <20230814121010.184842-3-marcus.folkesson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814121010.184842-3-marcus.folkesson@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023 at 02:10:07PM +0200, Marcus Folkesson wrote: > Replace the usage of `adc->spi->dev` with `dev` to make the code prettier. ... > u32 ref = MCP3911_INT_VREF_MV; > + struct device *dev = &adc->spi->dev; Keep it upper. > u32 div; > int ret; > u64 tmp; ... > + ret = devm_iio_triggered_buffer_setup(dev, indio_dev, > + NULL, This can be moved to the upper line. > + mcp3911_trigger_handler, NULL); > if (ret) > return ret; ... With above addressed, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko