From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>, <joro@8bytes.org>,
<alex.williamson@redhat.com>, <kevin.tian@intel.com>,
<robin.murphy@arm.com>, <baolu.lu@linux.intel.com>,
<cohuck@redhat.com>, <eric.auger@redhat.com>,
<kvm@vger.kernel.org>, <mjrosato@linux.ibm.com>,
<chao.p.peng@linux.intel.com>, <yi.y.sun@linux.intel.com>,
<peterx@redhat.com>, <jasowang@redhat.com>,
<shameerali.kolothum.thodi@huawei.com>, <lulu@redhat.com>,
<suravee.suthikulpanit@amd.com>, <iommu@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<zhenzhong.duan@intel.com>
Subject: Re: [PATCH v7 3/4] iommufd: Add IOMMU_GET_HW_INFO
Date: Tue, 15 Aug 2023 11:58:00 -0700 [thread overview]
Message-ID: <ZNvKuCFqCCWwIR24@Asurada-Nvidia> (raw)
In-Reply-To: <ZNvKZWcqrjp34zpe@nvidia.com>
On Tue, Aug 15, 2023 at 03:56:37PM -0300, Jason Gunthorpe wrote:
> On Tue, Aug 15, 2023 at 11:53:26AM -0700, Nicolin Chen wrote:
> > > ops = dev_iommu_ops(idev->dev);
> > > if (!ops->hw_info) {
> > > data = ops->hw_info(idev->dev, &data_len, &cmd->out_data_type);
> >
> > It should be:
> > if (ops->hw_info) {
>
> Hmm, the test suite probably needs some more stuff then too since it
> passed like that :)
Ack. I will see what I can do.
next prev parent reply other threads:[~2023-08-15 18:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 7:14 [PATCH v7 0/4] iommufd: Add iommu hardware info reporting Yi Liu
2023-08-11 7:14 ` [PATCH v7 1/4] iommu: Move dev_iommu_ops() to private header Yi Liu
2023-08-11 7:14 ` [PATCH v7 2/4] iommu: Add new iommu op to get iommu hardware information Yi Liu
2023-08-11 7:15 ` [PATCH v7 3/4] iommufd: Add IOMMU_GET_HW_INFO Yi Liu
2023-08-15 16:32 ` Jason Gunthorpe
2023-08-15 17:31 ` Nicolin Chen
2023-08-15 18:29 ` Jason Gunthorpe
2023-08-15 18:53 ` Nicolin Chen
2023-08-15 18:56 ` Jason Gunthorpe
2023-08-15 18:58 ` Nicolin Chen [this message]
2023-08-16 1:07 ` Nicolin Chen
2023-08-15 16:42 ` Jason Gunthorpe
2023-08-15 17:36 ` Nicolin Chen
2023-08-11 7:15 ` [PATCH v7 4/4] iommufd/selftest: Add coverage for IOMMU_GET_HW_INFO ioctl Yi Liu
2023-08-15 16:54 ` [PATCH v7 0/4] iommufd: Add iommu hardware info reporting Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNvKuCFqCCWwIR24@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox