From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBBE2C05052 for ; Wed, 16 Aug 2023 11:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244746AbjHPLqw (ORCPT ); Wed, 16 Aug 2023 07:46:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244767AbjHPLqa (ORCPT ); Wed, 16 Aug 2023 07:46:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DE081FC3; Wed, 16 Aug 2023 04:46:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1672A63E4C; Wed, 16 Aug 2023 11:46:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAD44C433C7; Wed, 16 Aug 2023 11:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692186387; bh=pFV0gcMmGAKm6F4azY/qV8aRse57Y/S2iw8UPyRiuBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m47ipfglakvCFAbG6FQ+Mjb1GbW6GHpUq0RWmYro/2CF2GPC/IZetIhNczDIsatFE Du73VYXriB0jF9zzJCSp0k1RRSsvOjvTAY0kL4LQ4dazRN8l4tIFdPWtXmOmWEk8YU K1HR7OfqQSE4WSxbCSSddwgiZkYqujdKLfwq44dZtJUGFenOD+1tHDqSdTvjZ/lWX1 QBhXF+294jGfSx03QDeNudqIPFrHDihsOdnTyP0gvWulwk8RhY7LL8PZAEVl/00yp7 lS2VQB47DtVS2HFMB4a3Dd27sdI708rg6YRFFaqSha9T9UADcqWcWshmKZrB0LqilI e10HreI00wnOA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BAB72404DF; Wed, 16 Aug 2023 08:46:23 -0300 (-03) Date: Wed, 16 Aug 2023 08:46:23 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> <20230816020715.GA135657@leoy-huanghe.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230816020715.GA135657@leoy-huanghe.lan> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Aug 16, 2023 at 10:07:15AM +0800, Leo Yan escreveu: > On Tue, Aug 15, 2023 at 03:57:17PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 15, 2023 at 03:52:38PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Tue, Aug 15, 2023 at 03:45:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > > Agreed, applied to perf-tools-next, sorry for the delay. > > > > > > > > Had to add this to make 'perf test python' to work. Please run 'perf > > > > test' before sending patches. > > > > > > One more, please also do a 'make -C tools/perf build-test', with it I > > > caught this: > > > > > > make_no_libunwind_O: cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH > > > cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH > > > > +#include "util/env.h" > > > > As now we need it for perf_env__arch(ui->machine->env) > > Sorry for inconvenience. > > I saw this patch series has been picked into the branch: > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf-tools-next > > If want me to follow up, let me know. Thank you! Right, I'll fix this ones: [perfbuilder@five ~]$ grep "unused variable" dm.log/*:* dm.log/ubuntu:18.04-x-m68k:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] dm.log/ubuntu:18.04-x-riscv64:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] dm.log/ubuntu:18.04-x-sh4:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] dm.log/ubuntu:18.04-x-sparc64:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] [perfbuilder@five ~]$ And move that to perf-tools-next, we can go on from there. The above is because we don't define CONFIG_PERF_REGS for these architectures and thus that variable ends up not being used, so I'm fixing up like below, in the cset where you made DWARF_MINIMAL_REGS receive the arch parameter. Also I haven't checked how gracefully we react when processing a perf.data collected in one of those unsupported arches, can you please check? - Arnaldo diff --git a/tools/perf/util/perf_regs.h b/tools/perf/util/perf_regs.h index 790c1a26bbfe9b4b..de1673057e502de9 100644 --- a/tools/perf/util/perf_regs.h +++ b/tools/perf/util/perf_regs.h @@ -32,9 +32,6 @@ extern const struct sample_reg sample_reg_masks[]; #include -#define DWARF_MINIMAL_REGS(arch) \ - ((1ULL << perf_arch_reg_ip(arch)) | (1ULL << perf_arch_reg_sp(arch))) - const char *perf_reg_name(int id, const char *arch); int perf_reg_value(u64 *valp, struct regs_dump *regs, int id); uint64_t perf_arch_reg_ip(const char *arch); @@ -67,11 +64,19 @@ const char *__perf_reg_name_x86(int id); uint64_t __perf_reg_ip_x86(void); uint64_t __perf_reg_sp_x86(void); +static inline uint64_t DWARF_MINIMAL_REGS(const char *arch) +{ + return (1ULL << perf_arch_reg_ip(arch)) | (1ULL << perf_arch_reg_sp(arch)); +} + #else #define PERF_REGS_MASK 0 #define PERF_REGS_MAX 0 -#define DWARF_MINIMAL_REGS(arch) PERF_REGS_MASK +static inline uint64_t DWARF_MINIMAL_REGS(const char *arch __maybe_unused) +{ + return PERF_REGS_MASK; +} static inline const char *perf_reg_name(int id __maybe_unused, const char *arch __maybe_unused) { > > > CC /tmp/tmp.yeEGyQq2HR/util/expr-flex.o > > > util/unwind-libdw.c: In function ‘memory_read’: > > > util/unwind-libdw.c:173:28: error: implicit declaration of function ‘perf_env__arch’ [-Werror=implicit-function-declaration] > > > 173 | const char *arch = perf_env__arch(ui->machine->env); > > > | ^~~~~~~~~~~~~~ > > > util/unwind-libdw.c:173:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] > > > util/unwind-libdw.c: In function ‘unwind__get_entries’: > > > util/unwind-libdw.c:258:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] > > > 258 | const char *arch = perf_env__arch(ui_buf.machine->env); > > > | ^~~~~~~~~~~~~~ > > > cc1: all warnings being treated as errors > > > make[6]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:98: /tmp/tmp.yeEGyQq2HR/util/unwind-libdw.o] Error 1 > > > make[6]: *** Waiting for unfinished jobs.... > > > make[5]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:150: util] Error 2 > > > make[4]: *** [Makefile.perf:662: /tmp/tmp.yeEGyQq2HR/perf-in.o] Error 2 > > > make[4]: *** Waiting for unfinished jobs.... > > > CC /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events.o > > > LD /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events-in.o > > > make[3]: *** [Makefile.perf:238: sub-make] Error 2 > > > make[2]: *** [Makefile:70: all] Error 2 > > > make[1]: *** [tests/make:337: make_no_libunwind_O] Error 1 > > > make: *** [Makefile:103: build-test] Error 2 > > > make: Leaving directory '/var/home/acme/git/perf-tools-next/tools/perf' > > > > > > real 1m29.784s > > > user 10m41.597s > > > sys 2m55.948s > > > ⬢[acme@toolbox perf-tools-next]$ > > > > > > I'm trying to fix > > > > -- > > > > - Arnaldo -- - Arnaldo