From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 56/62] mmc: renesas_sdhi: Convert to platform remove callback returning void
Date: Wed, 16 Aug 2023 13:27:38 +0200 [thread overview]
Message-ID: <ZNyyqlMFFZ2xPLUf@shikoro> (raw)
In-Reply-To: <20230727070051.17778-56-frank.li@vivo.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Thu, Jul 27, 2023 at 03:00:45PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Builds fine, boots fine, rebind works:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-16 11:35 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 6:59 [PATCH v3 01/62] mmc: sunxi: Convert to platform remove callback returning void Yangtao Li
2023-07-27 6:59 ` [PATCH v3 02/62] mmc: bcm2835: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 03/62] mmc: jz4740: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 04/62] mmc: litex_mmc: " Yangtao Li
2023-07-31 20:16 ` Gabriel L. Somlo
2023-07-27 6:59 ` [PATCH v3 05/62] mmc: mtk-sd: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 06/62] mmc: cb710: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 07/62] mmc: davinci_mmc: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 08/62] mmc: dw_mmc: hi3798cv200: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 09/62] mmc: sdhci-pic32: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 10/62] mmc: sdhci: milbeaut: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 11/62] mmc: omap_hsmmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 12/62] mmc: sdhci-of-at91: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 13/62] mmc: omap: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 14/62] mmc: dw_mmc: exynos: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 15/62] mmc: sdhci-pxav3: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 16/62] mmc: rtsx_pci: Drop if block with always false condition Yangtao Li
2023-07-27 7:00 ` [PATCH v3 17/62] mmc: rtsx_pci: Convert to platform remove callback returning void Yangtao Li
2023-07-27 7:00 ` [PATCH v3 18/62] mmc: sh_mmcif: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 19/62] mmc: meson-gx: " Yangtao Li
2023-07-29 19:01 ` Martin Blumenstingl
2023-07-27 7:00 ` [PATCH v3 20/62] mmc: xenon: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 21/62] mmc: sdhci-s3c: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 22/62] mmc: meson-mx-sdhc: " Yangtao Li
2023-07-29 19:01 ` Martin Blumenstingl
2023-07-27 7:00 ` [PATCH v3 23/62] mmc: rtsx_usb_sdmmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 24/62] mmc: mxs-mmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 25/62] mmc: sdhci-of-arasan: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 26/62] mmc: sdhci-of-dwcmshc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 27/62] mmc: au1xmmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 28/62] mmc: cavium-octeon: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 29/62] mmc: pxamci: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 30/62] mmc: moxart: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 31/62] mmc: sdhci-omap: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 32/62] mmc: sdhci-of-aspeed: remove unneeded variables Yangtao Li
2023-07-27 7:00 ` [PATCH v3 33/62] mmc: sdhci-of-aspeed: Convert to platform remove Yangtao Li
2023-07-27 7:00 ` [PATCH v3 34/62] mmc: meson-mx-sdio: Convert to platform remove callback returning void Yangtao Li
2023-07-29 19:02 ` Martin Blumenstingl
2023-07-27 7:00 ` [PATCH v3 35/62] mmc: sdhci-sprd: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 36/62] mmc: sdhci-tegra: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 37/62] mmc: sdhci-acpi: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 38/62] mmc: sdhci-esdhc-imx: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 39/62] mmc: sdhci-msm: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 40/62] mmc: alcor: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 41/62] mmc: dw_mmc: rockchip: " Yangtao Li
2023-07-28 18:24 ` Heiko Stuebner
2023-07-27 7:00 ` [PATCH v3 42/62] mmc: owl: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 43/62] mmc: wbsd: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 44/62] mmc: usdhi60rol0: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 45/62] mmc: atmel-mci: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 46/62] mmc: sdhci-st: " Yangtao Li
2023-08-28 9:10 ` Patrice CHOTARD
2023-07-27 7:00 ` [PATCH v3 47/62] mmc: wmt-sdmmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 48/62] mmc: sdhci-esdhc-mcf: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 49/62] mmc: sunplus-mmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 50/62] mmc: sdhci-spear: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 51/62] mmc: mxcmmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 52/62] mmc: mvsdio: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 53/62] mmc: pwrseq_simple: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 54/62] mmc: pwrseq: sd8787: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 55/62] mmc: pwrseq: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 56/62] mmc: renesas_sdhi: " Yangtao Li
2023-08-16 11:27 ` Wolfram Sang [this message]
2023-07-27 7:00 ` [PATCH v3 57/62] mmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 58/62] mmc: uniphier-sd: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 59/62] mmc: sdhci_am654: Properly handle failures in .remove() Yangtao Li
2023-07-27 13:56 ` Adrian Hunter
2023-07-27 7:00 ` [PATCH v3 60/62] mmc: sdhci_am654: Convert to platform remove callback returning void Yangtao Li
2023-07-27 13:56 ` Adrian Hunter
2023-07-27 7:00 ` [PATCH v3 61/62] mmc: f-sdh30: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 62/62] mmc: f-sdh30: fix order of function calls in sdhci_f_sdh30_remove Yangtao Li
2023-07-27 7:36 ` Uwe Kleine-König
2023-07-27 13:55 ` Adrian Hunter
2023-08-03 5:46 ` Adrian Hunter
2023-08-03 9:52 ` Uwe Kleine-König
2023-08-15 11:32 ` Ulf Hansson
2023-08-07 15:26 ` [PATCH v3 01/62] mmc: sunxi: Convert to platform remove callback returning void Ulf Hansson
2023-08-15 11:40 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNyyqlMFFZ2xPLUf@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=frank.li@vivo.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox