From: Yury Norov <yury.norov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v3 3/8] bitmap: fix opencoded bitmap_allocate_region()
Date: Mon, 28 Aug 2023 18:36:18 -0700 [thread overview]
Message-ID: <ZO1Lkhh3cjpYf1hm@yury-ThinkPad> (raw)
In-Reply-To: <ZN3sMzYHxQyvrKMJ@smile.fi.intel.com>
On Thu, Aug 17, 2023 at 12:45:23PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 15, 2023 at 04:36:23PM -0700, Yury Norov wrote:
> > bitmap_find_region() opencodes bitmap_allocate_region(). Fix it.
>
> ...
>
> > for (pos = 0; (end = pos + BIT(order)) <= bits; pos = end) {
> > - if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
> > - continue;
> > - __reg_op(bitmap, pos, order, REG_OP_ALLOC);
> > - return pos;
> > + if (!bitmap_allocate_region(bitmap, pos, order))
> > + return pos;
>
> You can also leave more code untouched, by replacing only first conditional
> with
>
> if (bitmap_allocate_region(bitmap, pos, order))
> continue;
> return pos;
This looks weird, and doesn't help preserving history because the
following patch moves everything from c-file to the header. I'd prefer
to keep this as is.
>
> > }
> > return -ENOMEM;
>
> --
> With Best Regards,
> Andy Shevchenko
>
next prev parent reply other threads:[~2023-08-29 1:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 23:36 [PATCH v3 0/8] bitmap: cleanup bitmap_*_region() implementation Yury Norov
2023-08-15 23:36 ` [PATCH v3 1/8] bitmap: align __reg_op() wrappers with modern coding style Yury Norov
2023-08-17 9:39 ` Andy Shevchenko
2023-08-17 14:22 ` Yury Norov
2023-08-17 15:47 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 2/8] bitmap: add test for bitmap_*_region() functions Yury Norov
2023-08-17 9:43 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 3/8] bitmap: fix opencoded bitmap_allocate_region() Yury Norov
2023-08-17 9:45 ` Andy Shevchenko
2023-08-29 1:36 ` Yury Norov [this message]
2023-08-15 23:36 ` [PATCH v3 4/8] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() Yury Norov
2023-08-17 9:46 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 5/8] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear() Yury Norov
2023-08-17 9:46 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 6/8] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit() Yury Norov
2023-08-15 23:36 ` [PATCH v3 7/8] bitmap: drop _reg_op() function Yury Norov
2023-08-17 9:47 ` Andy Shevchenko
2023-08-29 1:53 ` Yury Norov
2023-08-15 23:36 ` [PATCH v3 8/8] bitmap: move bitmap_*_region functions to bitmap.h Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO1Lkhh3cjpYf1hm@yury-ThinkPad \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox