From: Yury Norov <yury.norov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v3 7/8] bitmap: drop _reg_op() function
Date: Mon, 28 Aug 2023 18:53:21 -0700 [thread overview]
Message-ID: <ZO1OiVVxsXALqlGS@yury-ThinkPad> (raw)
In-Reply-To: <ZN3szFnWIBtFwg9K@smile.fi.intel.com>
On Thu, Aug 17, 2023 at 12:47:56PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 15, 2023 at 04:36:27PM -0700, Yury Norov wrote:
> > Now that all _reg_op() users are switched to alternative functions,
> > _reg_op() machinery is not needed anymore.
>
> ...
>
> > - * Can set, verify and/or release a region of bits in a bitmap,
> > - * depending on which combination of REG_OP_* flag bits is set.
> > - *
> > - * A region of a bitmap is a sequence of bits in the bitmap, of
> > - * some size '1 << order' (a power of two), aligned to that same
> > - * '1 << order' power of two.
>
> Just wondering if we have some equivalent to the above doc in the
> existing kernel doc of users of this.
This comment is not fully correct because the code doesn't enforce
alignment of the region. Let's drop this part just as well.
next prev parent reply other threads:[~2023-08-29 1:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 23:36 [PATCH v3 0/8] bitmap: cleanup bitmap_*_region() implementation Yury Norov
2023-08-15 23:36 ` [PATCH v3 1/8] bitmap: align __reg_op() wrappers with modern coding style Yury Norov
2023-08-17 9:39 ` Andy Shevchenko
2023-08-17 14:22 ` Yury Norov
2023-08-17 15:47 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 2/8] bitmap: add test for bitmap_*_region() functions Yury Norov
2023-08-17 9:43 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 3/8] bitmap: fix opencoded bitmap_allocate_region() Yury Norov
2023-08-17 9:45 ` Andy Shevchenko
2023-08-29 1:36 ` Yury Norov
2023-08-15 23:36 ` [PATCH v3 4/8] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() Yury Norov
2023-08-17 9:46 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 5/8] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear() Yury Norov
2023-08-17 9:46 ` Andy Shevchenko
2023-08-15 23:36 ` [PATCH v3 6/8] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit() Yury Norov
2023-08-15 23:36 ` [PATCH v3 7/8] bitmap: drop _reg_op() function Yury Norov
2023-08-17 9:47 ` Andy Shevchenko
2023-08-29 1:53 ` Yury Norov [this message]
2023-08-15 23:36 ` [PATCH v3 8/8] bitmap: move bitmap_*_region functions to bitmap.h Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO1OiVVxsXALqlGS@yury-ThinkPad \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox