From: Willy Tarreau <w@1wt.eu>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Zhangjin Wu" <falcon@tinylab.org>,
"Nicholas Rosenberg" <inori@vnlx.org>,
"Michael William Jonathan" <moe@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] tools/nolibc: i386: Fix a stack misalign bug on _start
Date: Tue, 29 Aug 2023 14:24:27 +0200 [thread overview]
Message-ID: <ZO3je2rNChZwp6Ay@1wt.eu> (raw)
In-Reply-To: <ZO3hxnKlWEbT/MPd@biznet-home.integral.gnuweeb.org>
On Tue, Aug 29, 2023 at 07:17:10PM +0700, Ammar Faizi wrote:
> On Tue, Aug 29, 2023 at 08:21:47AM +0200, Willy Tarreau wrote:
> > Indeed, good catch! However if we want to do it cleany (i.e not punch a
> > 16 to 28 byes hole in the stack), we should do this instead:
> >
> > add $12, %esp /* the stack must be aligned to 16 ... */
> > and $-16, %esp /* ... bytes after eax is pushed and ... */
> > sub $12, %esp /* ... before the call. */
> >
> > This will only add 0 to 12 bytes depending on the existing alignment.
> >
> > What do you think ?
>
> Good point. I'll send a v3 revision tomorrow.
OK thanks!
> I just saw that Linus has pulled the PR from Shuah that contains this
> bug. IOW, I missed this fix for the 6.6 merge window. Let's see if it
> can go to 6.6-rc2. Or maybe sooner than that.
No worries, we all know that -rc1 gets more exposure than individual
branches and raises bugs like this one.
Cheers,
Willy
next prev parent reply other threads:[~2023-08-29 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 7:02 [PATCH v2 0/1] Fix a stack misalign bug on _start Ammar Faizi
2023-08-28 7:02 ` [PATCH v2 1/1] tools/nolibc: i386: " Ammar Faizi
2023-08-29 6:21 ` Willy Tarreau
2023-08-29 12:17 ` Ammar Faizi
2023-08-29 12:24 ` Willy Tarreau [this message]
2023-08-29 8:37 ` Zhangjin Wu
2023-08-29 12:25 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3je2rNChZwp6Ay@1wt.eu \
--to=w@1wt.eu \
--cc=ammarfaizi2@gnuweeb.org \
--cc=falcon@tinylab.org \
--cc=gwml@vger.gnuweeb.org \
--cc=inori@vnlx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=moe@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox