public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v4 1/8] bitmap: align __reg_op() wrappers with modern coding style
Date: Tue, 29 Aug 2023 18:26:55 +0300	[thread overview]
Message-ID: <ZO4OP3tuQHa4adct@smile.fi.intel.com> (raw)
In-Reply-To: <20230829023911.64335-2-yury.norov@gmail.com>

On Mon, Aug 28, 2023 at 07:39:04PM -0700, Yury Norov wrote:
> Fix comments so that scripts/kernel-doc doesn't warn, and fix for-loop
> stype in bitmap_find_free_region().

...

> CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

When you have a tag, no need to have a separate Cc.
An in general, explicit Cc in the commit message make a lot of noise
and makes git index of the project fatter, you can use --cc parameter
when preparing / sending patches.

Other than that
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-08-29 15:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  2:39 [PATCH v4 0/8] bitmap: cleanup bitmap_*_region() implementation Yury Norov
2023-08-29  2:39 ` [PATCH v4 1/8] bitmap: align __reg_op() wrappers with modern coding style Yury Norov
2023-08-29 15:26   ` Andy Shevchenko [this message]
2023-08-29  2:39 ` [PATCH v4 2/8] bitmap: add test for bitmap_*_region() functions Yury Norov
2023-08-29 15:29   ` Andy Shevchenko
2023-08-29  2:39 ` [PATCH v4 3/8] bitmap: fix opencoded bitmap_allocate_region() Yury Norov
2023-08-29 15:30   ` Andy Shevchenko
2023-08-29  2:39 ` [PATCH v4 4/8] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() Yury Norov
2023-08-29  2:39 ` [PATCH v4 5/8] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear() Yury Norov
2023-08-29 15:32   ` Andy Shevchenko
2023-08-29  2:39 ` [PATCH v4 6/8] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit() Yury Norov
2023-08-29  2:39 ` [PATCH v4 7/8] bitmap: drop _reg_op() function Yury Norov
2023-08-29  2:39 ` [PATCH v4 8/8] bitmap: move bitmap_*_region() functions to bitmap.h Yury Norov
2023-08-29 10:07   ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZO4OP3tuQHa4adct@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox