* [PATCH] tick/nohz: remove unused tick_nohz_idle_stop_tick_protected()
@ 2023-08-13 13:11 Xueshi Hu
2023-08-29 16:11 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Xueshi Hu @ 2023-08-13 13:11 UTC (permalink / raw)
To: frederic, tglx, mingo; +Cc: linux-kernel, Xueshi Hu
All the caller has been removed since commit 336f560a8917 ("x86/xen: don't
let xen_pv_play_dead() return")
Signed-off-by: Xueshi Hu <xueshi.hu@smartx.com>
---
include/linux/tick.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/include/linux/tick.h b/include/linux/tick.h
index 9459fef5b857..716d17f31c45 100644
--- a/include/linux/tick.h
+++ b/include/linux/tick.h
@@ -140,14 +140,6 @@ extern unsigned long tick_nohz_get_idle_calls(void);
extern unsigned long tick_nohz_get_idle_calls_cpu(int cpu);
extern u64 get_cpu_idle_time_us(int cpu, u64 *last_update_time);
extern u64 get_cpu_iowait_time_us(int cpu, u64 *last_update_time);
-
-static inline void tick_nohz_idle_stop_tick_protected(void)
-{
- local_irq_disable();
- tick_nohz_idle_stop_tick();
- local_irq_enable();
-}
-
#else /* !CONFIG_NO_HZ_COMMON */
#define tick_nohz_enabled (0)
static inline int tick_nohz_tick_stopped(void) { return 0; }
@@ -170,8 +162,6 @@ static inline ktime_t tick_nohz_get_sleep_length(ktime_t *delta_next)
}
static inline u64 get_cpu_idle_time_us(int cpu, u64 *unused) { return -1; }
static inline u64 get_cpu_iowait_time_us(int cpu, u64 *unused) { return -1; }
-
-static inline void tick_nohz_idle_stop_tick_protected(void) { }
#endif /* !CONFIG_NO_HZ_COMMON */
#ifdef CONFIG_NO_HZ_FULL
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tick/nohz: remove unused tick_nohz_idle_stop_tick_protected()
2023-08-13 13:11 [PATCH] tick/nohz: remove unused tick_nohz_idle_stop_tick_protected() Xueshi Hu
@ 2023-08-29 16:11 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2023-08-29 16:11 UTC (permalink / raw)
To: Xueshi Hu; +Cc: tglx, mingo, linux-kernel
On Sun, Aug 13, 2023 at 09:11:53PM +0800, Xueshi Hu wrote:
> All the caller has been removed since commit 336f560a8917 ("x86/xen: don't
> let xen_pv_play_dead() return")
>
> Signed-off-by: Xueshi Hu <xueshi.hu@smartx.com>
Applied to my pending queue, thanks!
> ---
> include/linux/tick.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/tick.h b/include/linux/tick.h
> index 9459fef5b857..716d17f31c45 100644
> --- a/include/linux/tick.h
> +++ b/include/linux/tick.h
> @@ -140,14 +140,6 @@ extern unsigned long tick_nohz_get_idle_calls(void);
> extern unsigned long tick_nohz_get_idle_calls_cpu(int cpu);
> extern u64 get_cpu_idle_time_us(int cpu, u64 *last_update_time);
> extern u64 get_cpu_iowait_time_us(int cpu, u64 *last_update_time);
> -
> -static inline void tick_nohz_idle_stop_tick_protected(void)
> -{
> - local_irq_disable();
> - tick_nohz_idle_stop_tick();
> - local_irq_enable();
> -}
> -
> #else /* !CONFIG_NO_HZ_COMMON */
> #define tick_nohz_enabled (0)
> static inline int tick_nohz_tick_stopped(void) { return 0; }
> @@ -170,8 +162,6 @@ static inline ktime_t tick_nohz_get_sleep_length(ktime_t *delta_next)
> }
> static inline u64 get_cpu_idle_time_us(int cpu, u64 *unused) { return -1; }
> static inline u64 get_cpu_iowait_time_us(int cpu, u64 *unused) { return -1; }
> -
> -static inline void tick_nohz_idle_stop_tick_protected(void) { }
> #endif /* !CONFIG_NO_HZ_COMMON */
>
> #ifdef CONFIG_NO_HZ_FULL
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-29 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-13 13:11 [PATCH] tick/nohz: remove unused tick_nohz_idle_stop_tick_protected() Xueshi Hu
2023-08-29 16:11 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox