public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrey Skvortsov <andrej.skvortzov@gmail.com>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	icenowy@aosc.xyz, martijn@brixit.nl, megous@megous.com,
	kernel list <linux-kernel@vger.kernel.org>,
	phone-devel@vger.kernel.org, mchehab@kernel.org,
	linux-media@vger.kernel.org, megi@xff.cz
Subject: Re: gc2145 camera driver (front camera on PinePhone)
Date: Sun, 20 Aug 2023 20:38:44 +0300	[thread overview]
Message-ID: <ZOJPpBoiC92VsOV+@skv.local> (raw)
In-Reply-To: <Y6tGfxrq/Mh1JoA9@duo.ucw.cz>

Hi Alain,

> we are also using the GC2145 sensor but in a CSI based environment.
> 
> We are in contact with GalaxyCore and following discussions we had with them
> and data they provided us with, we've made a driver for that, supporting for
> the time being 3 different resolutions via the CSI interface.
> 
> The driver is available on the STMicroelectronics STM32 github [1].
> 
> If you are ok with that, we could go further upstreaming it while testing/adding
> features necessary for the PinePhone.
> 
> [1] https://github.com/STMicroelectronics/linux/blob/v5.15-stm32mp/drivers/media/i2c/gc2145.c

I've implemented basic parallel bus support to check your driver [1] on
the PinePhone. My changes are here [2].
With your driver results are much better in compare to Megi's
driver (I'm still glad, that Megi has written one). See pictures for
comparison here [3]. Access to vendor support and (probably)
documentation gives great results.

I'd recommend to replace more of hard-coded parts of initialization
sequences with functions like in proposed Megi's driver. So this will
be clearer what different register values mean. Since you have access
to support channel/documentation it'd be easier for you to do.

It'd be nice to have at least some gc2145 driver in mainline. Do you
still have plans/time to mainline driver?

P.S.
Alain, I don't see your address in the list of recipients of last Pavel's
response. In case you have not received it, it's here [4].

1. https://github.com/STMicroelectronics/linux/blob/v6.1-stm32mp/drivers/media/i2c/gc2145.c
2. https://github.com/AndreySV/linux/commit/f06ff60eb7a664dcafa8d40901a1ab0f59071529
3. https://github.com/AndreySV/linux/issues/1
4. https://lwn.net/ml/linux-kernel/Y6tGfxrq/Mh1JoA9@duo.ucw.cz
-- 
Best regards,
Andrey Skvortsov

  reply	other threads:[~2023-08-20 17:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 18:05 gc2145 camera driver (front camera on PinePhone) Pavel Machek
2022-08-22 18:20 ` Ondřej Jirman
2022-08-22 20:50   ` Pavel Machek
2022-09-08  7:36 ` Alain Volmat
2022-12-27 19:24   ` Pavel Machek
2023-08-20 17:38     ` Andrey Skvortsov [this message]
2023-08-29 14:40       ` Alain Volmat
2023-08-29 16:22         ` Andrey Skvortsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOJPpBoiC92VsOV+@skv.local \
    --to=andrej.skvortzov@gmail.com \
    --cc=alain.volmat@foss.st.com \
    --cc=icenowy@aosc.xyz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martijn@brixit.nl \
    --cc=mchehab@kernel.org \
    --cc=megi@xff.cz \
    --cc=megous@megous.com \
    --cc=pavel@ucw.cz \
    --cc=phone-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox