From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A25C6EE4996 for ; Mon, 21 Aug 2023 12:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235127AbjHUM4S (ORCPT ); Mon, 21 Aug 2023 08:56:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235102AbjHUM4R (ORCPT ); Mon, 21 Aug 2023 08:56:17 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F391D3 for ; Mon, 21 Aug 2023 05:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bZuXrJnycDPuWsVWT2G7AaUlErg2xS9Lt8LBAxiLYG8=; b=0dc2CaV81hgg0b9IKZ6hSLULgy +rz0Vi9EuPClZOLAAnIPmA632QV1vODZhVwckDuAEGo4dQAfs0QIEe21qFLqukhI3JQIJ+nlru49B G889dqmgZfC70ftNtB0w1I9UmwY6flzLmLvM60VsDx0x3J9XhwIDlpR2zX8wzUB/ZzoBFMQbYip14 RS8F0G9yTMvfNy83FeiLA1FA7nhaFn7bMHkd2XHRenfxNNKtdHGNDSsPQqmpZVSDngDPBPx7u4gez 88aaTXi394snz9GXA4BGLNCk7gqdQcjb0dGbG79vlAZTpN8/ZtgaZTzihcakvYlFdfDWOycPae1lf e+EhE6+Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41892) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qY4Rz-0008Va-2B; Mon, 21 Aug 2023 13:56:07 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qY4Rz-0004mn-3l; Mon, 21 Aug 2023 13:56:07 +0100 Date: Mon, 21 Aug 2023 13:56:07 +0100 From: "Russell King (Oracle)" To: Helge Deller Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH][RESEND] arm: Fix flush_dcache_page() for usage from irq context Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 18, 2023 at 10:58:09PM +0200, Helge Deller wrote: > Since at least kernel 6.1, flush_dcache_page() is called with IRQs > disabled, e.g. from aio_complete(). > > But the current implementation for flush_dcache_page() on ARM (32-bit) > unintentionally re-enables IRQs, which may lead to deadlocks. > > Fix it by using xa_lock_irqsave() and xa_unlock_irqrestore() > for the flush_dcache_mmap_*lock() macros instead. > > Cc: "Russell King (Oracle)" > Cc: Arnd Bergmann > Cc: linux-arm-kernel@lists.infradead.org > Reviewed-by: Arnd Bergmann > Signed-off-by: Helge Deller Please submit to the patch system, details can be found in my email signature below. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!