Re: [PATCH v3 05/11] iommu: Merge iopf_device_param into iommu_fault_param

Jason Gunthorpe
2023-08-21T17:04:44Z

On Fri, Aug 18, 2023 at 07:40:41AM +0800, Lu Baolu wrote:
> @@ -472,21 +473,31 @@ struct iommu_fault_event {
> * struct iommu_fault_param - per-device IOMMU fault data
> * @handler: Callback function to handle IOMMU faults at device level
> * @data: handler private data
> - * @faults: holds the pending faults which needs response
> * @lock: protect pending faults list
> + * @dev: the device that owns this param
> + * @queue: IOPF queue
> + * @queue_list: index into queue->devices
> + * @partial: faults that are part of a Page Request Group for which the last
> + * request hasn't been submitted yet.
> + * @faults: holds the pending faults which needs response
> */
> struct iommu_fault_param {
> iommu_dev_fault_handler_t handler;
> void *data;
> - struct list_head faults;
> - struct mutex lock;
> + struct mutex lock;
> +
> + struct device *dev;
> + struct iopf_queue *queue;
> + struct list_head queue_list;
> +
> + struct list_head partial;
> + struct list_head faults;
> };

Don't add the horizontal spaces

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason
-