From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FB9EE49A6 for ; Mon, 21 Aug 2023 17:04:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236919AbjHUREo (ORCPT ); Mon, 21 Aug 2023 13:04:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236894AbjHUREn (ORCPT ); Mon, 21 Aug 2023 13:04:43 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CA8BED for ; Mon, 21 Aug 2023 10:04:41 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-6490c2c4702so18261956d6.2 for ; Mon, 21 Aug 2023 10:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1692637480; x=1693242280; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N09QE0C3lW8oGWF50bQOxZXPyK36qtYOYonsxv0HH8c=; b=W8UiYFg+/p47ajmvb6c1GFVVsTww14hmsjS5g9VC4iS2FHmq5Kh2J4UXCkjHEV2psl wOnx7oxSVJMPy87Jhn+p/NmwbERhsnldbAJss4S/NI39ueJJE3zW0AlKAPZ1xL7/5RWE ZmAKI6n90zrXzrNKDL22m3mDMYky5E6pY9IDza2nNh92AXqoQQtwzfBMGtLzId4zpzf6 cqqfU6USK+z9/mpRopcvcmWHGSCak6EZxzEUMDK0bepYk8UrqpqCrsO9h4NhxMJm0Ri6 BYJy5qoIh2ZLiXuISwm8iYIwh/bXAZRTBxunmW2e1/CZcg/8bpG+tPoRTTHRR+susG1M 6gCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692637480; x=1693242280; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N09QE0C3lW8oGWF50bQOxZXPyK36qtYOYonsxv0HH8c=; b=X8hlTj8OdVBThMhH1gwinl2OGvl4fdjzf8/ssrZLD3qqGJHXVQrwwSy3g86f9Yi53q W+7XrpQg3ve8ciX/LKmj0dOakVdiEguBGUCyGseVbK5htg2TZJdM6SQZyqyRjKuDlv4V zd28dVCuuLfTEZ60cNehczs/J5P7gFYfGObux3QewrSdmOxQSuX9ntymVACtzqCI2DnS UE81kRNVYOpnFgMh1NClS9MgzS2oTud2+pemCc9HKXkZhaNzQFaUOBzvPCUl4oqaaAtq oRTY7avxRbrLeG8DVWA0nbMenzw39eEpN51nt3m+mF9ESRjCzYr6CMxUOzJyDe48SmMx GkYw== X-Gm-Message-State: AOJu0YxqcFy5m6SxXgdJebJLQE9pqt/Zb8n2HwFQ/U5ExDpUpTMEwQCc hlyc9PAlMrupTIEs+KmFN6mvwA== X-Google-Smtp-Source: AGHT+IFE3U9YWvQ4iNtyRxFqDyhWmNE+Ii8wn6FvWBNTRn+lXBSa2bgUJEP4lLxtiNKJjpRUuW8z8w== X-Received: by 2002:a0c:a9d8:0:b0:64f:3b07:c50b with SMTP id c24-20020a0ca9d8000000b0064f3b07c50bmr5161926qvb.43.1692637480297; Mon, 21 Aug 2023 10:04:40 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id i26-20020a05620a145a00b00767b0c35c15sm2590622qkl.91.2023.08.21.10.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 10:04:39 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qY8KV-00Duwr-Bb; Mon, 21 Aug 2023 14:04:39 -0300 Date: Mon, 21 Aug 2023 14:04:39 -0300 From: Jason Gunthorpe To: Lu Baolu Cc: Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Jean-Philippe Brucker , Nicolin Chen , Yi Liu , Jacob Pan , iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/11] iommu: Merge iopf_device_param into iommu_fault_param Message-ID: References: <20230817234047.195194-1-baolu.lu@linux.intel.com> <20230817234047.195194-6-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817234047.195194-6-baolu.lu@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 18, 2023 at 07:40:41AM +0800, Lu Baolu wrote: > @@ -472,21 +473,31 @@ struct iommu_fault_event { > * struct iommu_fault_param - per-device IOMMU fault data > * @handler: Callback function to handle IOMMU faults at device level > * @data: handler private data > - * @faults: holds the pending faults which needs response > * @lock: protect pending faults list > + * @dev: the device that owns this param > + * @queue: IOPF queue > + * @queue_list: index into queue->devices > + * @partial: faults that are part of a Page Request Group for which the last > + * request hasn't been submitted yet. > + * @faults: holds the pending faults which needs response > */ > struct iommu_fault_param { > iommu_dev_fault_handler_t handler; > void *data; > - struct list_head faults; > - struct mutex lock; > + struct mutex lock; > + > + struct device *dev; > + struct iopf_queue *queue; > + struct list_head queue_list; > + > + struct list_head partial; > + struct list_head faults; > }; Don't add the horizontal spaces Reviewed-by: Jason Gunthorpe Jason -