From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 1/1] serial: core: Remove unused PORT_* definitions
Date: Tue, 22 Aug 2023 16:20:16 +0300 [thread overview]
Message-ID: <ZOS2EOiXOn1tjKAS@smile.fi.intel.com> (raw)
In-Reply-To: <2023082210-clasp-guru-0456@gregkh>
On Tue, Aug 22, 2023 at 02:59:37PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 21, 2023 at 11:38:57AM +0300, Andy Shevchenko wrote:
> > For the last couple of years Linux kernel got rid of a few architectures
> > and many platforms. Hence some PORT_* definitions in the serial_core.h
> > become unused and redundant. Remove them for good.
> >
> > Removed IDs are checked for users against Debian Code Search engine.
> > Hence safe to remove as there are no consumers found (only providers).
> >
> > While at it, add a note about 0-13, that are defined in the other file.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v2: tested via DCS (Greg), dropped 1 change due to that, added a note for 0-13
> > include/uapi/linux/serial_core.h | 43 +++-----------------------------
> > 1 file changed, 3 insertions(+), 40 deletions(-)
>
> You forgot to cc linux-serial@vger :)
Oh, that's because I cooked this patch against v6.5-rcX, where X < 7, and hence
the 238500e2d67c ("MAINTAINERS: Merge TTY layer and serial drivers") is absent.
> I'll take this now, thanks for cleaning this up. Hopefully we can
> resist the urge to add new ids here.
Thank you!
I want to compress the list based on DCS research, it seems feasible and may
shrink a lot of memory at run-time for the port structure. Let me check that.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-22 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 8:38 [PATCH v2 1/1] serial: core: Remove unused PORT_* definitions Andy Shevchenko
2023-08-22 12:59 ` Greg Kroah-Hartman
2023-08-22 13:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOS2EOiXOn1tjKAS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox