From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FD5EE4996 for ; Tue, 22 Aug 2023 13:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236138AbjHVNjw (ORCPT ); Tue, 22 Aug 2023 09:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbjHVNju (ORCPT ); Tue, 22 Aug 2023 09:39:50 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1311018B; Tue, 22 Aug 2023 06:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692711589; x=1724247589; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=y1OTxgbGeAr+sq4oKE3VCclLzYN1bhwn+vqbXNQvBR8=; b=gWpBsd0iORaWIbpxLtMrxQEsRwjJXXUYi/Tb7qLUDMFLoKRyVOl4RsgU tAzgpYCk5uZmt82Ftjn68iq8kacD3XHdOGD/XbfroXlojHZlAJmPibnab De0yxrk7mIi+sjleA4v4poV+UU6tVTZxWPWxKSxNRQyhVQRgCKFXq42Hp esU7eJIvzlPLZiYUOXb6i01FRJKzX3mmwoXWc98Qo+kzEo6W1WQ542q0o xPWXZnSQxp4p00fdomVoJmC5tAYPY1pFpPdDlBoBRuH4PFyzy0/i79BYf wv4hkLM03K5vu4xG9IURFdiz80Ld2QlS1Ns7UudCb37AAUKlJexafaUpv g==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="440245483" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="440245483" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 06:39:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="879957267" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 22 Aug 2023 06:39:49 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 22 Aug 2023 16:39:43 +0300 Date: Tue, 22 Aug 2023 16:39:43 +0300 From: Heikki Krogerus To: Dmitry Baryshkov Cc: Bryan O'Donoghue , Guenter Roeck , Andy Gross , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] usb: typec: altmodes/displayport: add support for embedded DP cases Message-ID: References: <20230817150824.14371-1-dmitry.baryshkov@linaro.org> <20230817150824.14371-2-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817150824.14371-2-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2023 at 06:08:23PM +0300, Dmitry Baryshkov wrote: > In the embedded cases, the DisplayPort connector is handled by the TCPM > itself. It was proposed to add the "displayport" OF property to the DT > bindings, but it was rejected in favour of properly describing the > electrical signal path using of_graph. > > Fallback to the controller fwnode for HPD notifications to > support such usecases without requiring additional DT properties. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/altmodes/displayport.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index bc4af130940d..a4cf1045b535 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -594,7 +594,10 @@ int dp_altmode_probe(struct typec_altmode *alt) > alt->ops = &dp_altmode_ops; > > fwnode = dev_fwnode(alt->dev.parent->parent); /* typec_port fwnode */ > - dp->connector_fwnode = fwnode_find_reference(fwnode, "displayport", 0); > + if (fwnode_property_present(fwnode, "displayport")) > + dp->connector_fwnode = fwnode_find_reference(fwnode, "displayport", 0); > + else > + dp->connector_fwnode = fwnode_handle_get(fwnode); /* embedded DP */ > if (IS_ERR(dp->connector_fwnode)) > dp->connector_fwnode = NULL; > > -- > 2.39.2 -- heikki