From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A083EE49A4 for ; Tue, 22 Aug 2023 12:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235527AbjHVMEr (ORCPT ); Tue, 22 Aug 2023 08:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235161AbjHVMEq (ORCPT ); Tue, 22 Aug 2023 08:04:46 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B406D1; Tue, 22 Aug 2023 05:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692705885; x=1724241885; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eztHma/mzu8sG2UYtgl/yLjwZ9Wr42jHwVgx08YQoeY=; b=CEVWpBSm88VDB8g6tLKP8NitiX+L3pe++9oGKl1YhF/1fOa7wNZhzfzy W5ZYkZ47WaPW2iqsnZApLkpLywXJ+avUcNCwvThXyIueK+fpzTiaK1fTm BMoHh+w9nDPgtnwBUf5V4mBF8TtGVFGq28X+2I7IfH8ZbZ1CGu+0gEHZd W/XyjkufOQsPWc2EmgpTRjbMH1Gj6rmAPfwlHvt2t4jpEi7Zdqo7AbjlS wG+67MAUeVmbHVxqfs+IzQUDmd4A/2cMnjBDeaP2nsukUVeyyaGZY+SE0 H7vv8otdTfPBgtnC8h3zVLg4j7jEQAjZgj8ewpmqoPt77uBVwK0tEN8Ee Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="353425370" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="353425370" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 05:04:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="771333640" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="771333640" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 22 Aug 2023 05:04:37 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qYQ7f-009Ken-1x; Tue, 22 Aug 2023 15:04:35 +0300 Date: Tue, 22 Aug 2023 15:04:35 +0300 From: Andy Shevchenko To: Yann Sionneau Cc: Jarkko Nikula , Mika Westerberg , Julian Vetter , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C function to GPIO function, the recovery won't work. Message-ID: References: <20230822091555.18015-1-ysionneau@kalray.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230822091555.18015-1-ysionneau@kalray.eu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2023 at 11:15:55AM +0200, Yann Sionneau wrote: > scl-gpio = <>; > sda-gpio = <>; > > Are not enough for some SoCs to have a working recovery. > Some need: > > scl-gpio = <>; > sda-gpio = <>; > pinctrl-names = "default", "recovery"; > pinctrl-0 = <&i2c_pins_hw>; > pinctrl-1 = <&i2c_pins_gpio>; > > The driver was not filling rinfo->pinctrl with the device node > pinctrl data which is needed by generic recovery code. With or without my suggestion, FWIW, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko